-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab cli Updated for version 1.48.0 #8462
Conversation
reverse dependencies - development/gitlab-cliNone |
✅ sbolint - development/gitlab-cli ✅
|
@sbo-bot: build development/gitlab-cli |
buildpkg i586 development/gitlab-cli
Snipped Build Failure
|
buildpkg x86_64 development/gitlab-cli
Snipped Build Failure
|
@DinizBortolotto this failed to build |
Gitlab changed their goreleaser filename template so we needed to fix SlackBuild. |
@@ -26,30 +26,26 @@ cd $(dirname $0) ; CWD=$(pwd) | |||
|
|||
PRGNAM=gitlab-cli | |||
DEBNAM=glab | |||
VERSION=${VERSION:-1.46.1} | |||
DEBARCH=amd64 | |||
VERSION=${VERSION:-1.48.0} | |||
BUILD=${BUILD:-1} | |||
TAG=${TAG:-_SBo} | |||
PKGTYPE=${PKGTYPE:-tgz} | |||
|
|||
if [ -z "$ARCH" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work if someone has ARCH already set in the env.
The previous code which checked for an empty ARCH, then set it. And then a separate if block built the DEBARCH var based on it was correct.
Could you revert that change?
@sbo-bot: build development/gitlab-cli |
buildpkg i586 development/gitlab-cli
Snipped Build Failure
|
buildpkg x86_64 development/gitlab-cli
Snipped Build Log
|
sbopkglint x86_64 development/gitlab-cli
|
this solves for x86_64 only, so the best option is to restore the ARCH check like what @aclemons suggested |
@sbo-bot: build development/gitlab-cli |
buildpkg i586 development/gitlab-cli
Snipped Build Log
|
sbopkglint i586 development/gitlab-cli
|
buildpkg x86_64 development/gitlab-cli
Snipped Build Log
|
sbopkglint x86_64 development/gitlab-cli
|
merged |
Tks for your support and sorry for the mess in git log. Im still learning that. |
No description provided.