Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: default OnPremiseAPISuffix chnaged to 'v1' from '/v1' #33

Merged

Conversation

arumoy
Copy link
Contributor

@arumoy arumoy commented Oct 25, 2023

OkHttp adds the slashes as necessary, but can't navigate if there is // in the API path.
Setting the default suffix to /v1 was evaluating to host//v1/apis... and failing to fetch the spec with a 404

OkHttp does it and can't sanitise if already applied
@barryadk barryadk self-assigned this Oct 25, 2023
@barryadk barryadk removed their assignment Oct 25, 2023
@barryadk barryadk merged commit 9120ad6 into SmartBear:main Oct 25, 2023
1 check passed
@arumoy
Copy link
Contributor Author

arumoy commented Oct 25, 2023

Just leaving a comment in case this isn't usual behaviour for the pipeline, the release hasn't made it to public gradle repo.

https://plugins.gradle.org/plugin/io.swagger.swaggerhub/1.3.1 - chucks up a 404.

@barryadk
Copy link
Contributor

Thanks for the comment @arumoy . I missed a step in the release process for 1.3.1, so I've released 1.3.2 instead. The 1.3.2 release includes the change from this PR.
https://plugins.gradle.org/plugin/io.swagger.swaggerhub/1.3.2

@arumoy
Copy link
Contributor Author

arumoy commented Oct 25, 2023

Thanks a lot for this, @barryadk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants