Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix short address decoding #13

Closed
wants to merge 1 commit into from
Closed

Fix short address decoding #13

wants to merge 1 commit into from

Conversation

k06a
Copy link

@k06a k06a commented Oct 23, 2018

Example addresses:

0x0014F55A50b281EFD12294f0Cda821Bd8171e920
0x0000000000000000000000000000000000000000

@k06a
Fix short address decoding
35182b3 
Example addresses:
```
0x0014F55A50b281EFD12294f0Cda821Bd8171e920
0x0000000000000000000000000000000000000000
```
yaronvel
yaronvel requested changes Oct 26, 2018
View reviewed changes
Copy link
Collaborator

@yaronvel yaronvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain the motivation for the change?
Also please PR to develop branch.

But more important to explain the motivation. it is not clear to me.

@k06a
Copy link
Author

k06a commented Oct 27, 2018

@yaronvel some RLP encoder implementations could handle Solidity address type as number and some addresses with first zero bytes could be encoded with less than 20 bytes.

@k06a
Copy link
Author

k06a commented Oct 27, 2018 •
edited
Loading

Created PR for develop branch #14

@k06a k06a closed this Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaronvel yaronvel yaronvel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k06a @yaronvel