Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix short address decoding (develop branch) #14

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

k06a
Copy link

@k06a k06a commented Oct 27, 2018

Example addresses:

0x0014F55A50b281EFD12294f0Cda821Bd8171e920
0x0000000000000000000000000000000000000000

Example addresses:
```
0x0014F55A50b281EFD12294f0Cda821Bd8171e920
0x0000000000000000000000000000000000000000
```
@k06a k06a mentioned this pull request Oct 27, 2018
@yaronvel
Copy link
Collaborator

Hi, thanks for changing the branch.
But still, can you explain why this change is needed?
why should we support addresses longer than 20 bytes?

@k06a
Copy link
Author

k06a commented Oct 28, 2018

@yaronvel no, you should support addresses shorter than 20 bytes, because it could contain first zero bytes for the probability reasons.

Encoders could encode addresses as numbers and use for example 19 or 18 bytes for some addresses, this is an absolutely valid case for abstract RLP encoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants