Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/wip multi auth #730

Merged
merged 37 commits into from
Jul 12, 2023
Merged

Feat/wip multi auth #730

merged 37 commits into from
Jul 12, 2023

Conversation

nicktaras
Copy link
Collaborator

@nicktaras nicktaras commented Jun 21, 2023

Hi @micwallace, @oleggrib,

Please see this PR towards adding multi-token support to Token Negotiator.

This enables;

  • redirect, tab and iframe modes to support multi token authentication requests for a single issuer outlet.
  • tested via Chrome, Safari, FF and Brave for passive and active flows

For any testing towards review please use the feat/wip-mulit-auth branch in examples:

  • Hotel Bogota Active, select the tokens to auth, then click 'book now'
  • Ticket Issuer Outlet, select 2 tokens to authenticate

I will spend a few more hours on this today, to reduce/remove any added duplications from the changes added. But the core implementation will stay the same.

Thanks guys.

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
38.43% (-1.78% 🔻)
1338/3482
🔴 Branches
24.78% (-1.7% 🔻)
372/1501
🔴 Functions
38.62% (-1.6% 🔻)
185/479
🔴 Lines
38.72% (-1.71% 🔻)
1135/2931
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / attestationIdClient.ts
8.29% 0% 7.14% 8.48%
🔴
... / getUseToken.ts
21.21% 0% 0% 19.35%
🔴
... / ticketZKProofMulti.ts
24.64% 0% 11.11% 25.42%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 client/index.ts
42.17% (-5.83% 🔻)
40.53% (-5.43% 🔻)
53.85% (-2.91% 🔻)
43.02% (-5.66% 🔻)
🔴 client/ui.ts 48.84%
25.96% (-0.77% 🔻)
43.75% 50.79%
🔴
... / localOutlet.ts
29.55% (-13.31% 🔻)
0%
33.33% (+13.33% 🔼)
34.29% (-10.16% 🔻)
🔴
... / ticketStorage.ts
32.47% (-1.12% 🔻)
5% (-0.26% 🔻)
25%
35.25% (-0.94% 🔻)
🔴 outlet/index.ts
19.64% (-4.12% 🔻)
13.56% (+0.52% 🔼)
22.22% (-7.19% 🔻)
20.71% (-4.44% 🔻)
🔴 outlet/whitelist.ts
31.31% (+0.39% 🔼)
6% (-0.12% 🔻)
28.57%
31.43% (+0.99% 🔼)

Test suite run success

86 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 1386861

@nicktaras nicktaras marked this pull request as ready for review July 3, 2023 02:57
@nicktaras nicktaras requested a review from oleggrib July 3, 2023 02:57
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
src/outlet/index.ts Outdated Show resolved Hide resolved
src/outlet/index.ts Outdated Show resolved Hide resolved
src/outlet/index.ts Outdated Show resolved Hide resolved
@nicktaras nicktaras requested a review from oleggrib July 4, 2023 02:59
Nick Taras and others added 12 commits July 5, 2023 13:24
Create new attestation ID client with request storage.
This will prevent unnecessary redirects to attestation.id
when authenticating tokens with multiple email addresses.
Various fixes and tidying up.
Implement client class ZKProof construction so there is no
reliance on Outlet class when using Client only.
Bug fixes preventing storage of ID attestation from callback.
…ents

Feat: improvements to multi-token authentication
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micwallace micwallace merged commit 9fb9622 into staging Jul 12, 2023
5 checks passed
@micwallace micwallace deleted the feat/wip-multi-auth branch September 18, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants