-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/wip multi auth #730
Merged
Merged
Feat/wip multi auth #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success86 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 1386861 |
…henticate cross origin
…henticate cross origin
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
oleggrib
reviewed
Jul 3, 2023
Create new attestation ID client with request storage. This will prevent unnecessary redirects to attestation.id when authenticating tokens with multiple email addresses.
Various fixes and tidying up.
Implement client class ZKProof construction so there is no reliance on Outlet class when using Client only.
Bug fixes preventing storage of ID attestation from callback.
…ents Feat: improvements to multi-token authentication
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
micwallace
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @micwallace, @oleggrib,
Please see this PR towards adding multi-token support to Token Negotiator.
This enables;
For any testing towards review please use the feat/wip-mulit-auth branch in examples:
I will spend a few more hours on this today, to reduce/remove any added duplications from the changes added. But the core implementation will stay the same.
Thanks guys.