feat: add support for multipart downloading of a translated file to Files API #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnetrebenko-smartling
requested review from
dimitrystd and
sl-mmuradov
as code owners
dnetrebenko-smartling
requested review from
andy-radchenko,
AlexArcher and
AlexanderNovak
sl-mmuradov
reviewed
Aug 13, 2024
...files-api/src/main/java/com/smartling/api/files/v2/resteasy/ext/TranslatedFileMultipart.java
Outdated
Show resolved
Hide resolved
sl-mmuradov
approved these changes
Aug 13, 2024
sl-pkryshtop
approved these changes
Aug 13, 2024
smartling-files-api/src/main/java/com/smartling/api/files/v2/FilesApiFactory.java
Outdated
Show resolved
Hide resolved
vfisyuk-smartling
approved these changes
Aug 14, 2024
dnetrebenko-smartling
deleted the
DEVORTEX-4870-Multipart-file-download
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new method to download a translated file in the multipart/mixed format is added to Files API. the first part is file's body, the second part is json metadata (empty for now, we use it just to be sure that entire file was downloaded, maybe we will extend it with some additional data in the future)