Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests for ArrayView indexing.
Note: No tests were added for floats. I presumed floats should not work and would throw an exception, but they work and return values. I recommend clearly defining what the behavior for floats should be and add unit tests to document this.
For reference in Python:
Also, it was not clear what the distinction between
KeyError
andIndexError
is. The unit tests assert what is currently being thrown.