Update API tests using factories #170
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaarendt
added
enhancement
aaarendt
requested review from
micah-prime,
micahjohnson150 and
jomey
as code owners
jomey
reviewed
Nov 1, 2024
| result = clz().all_observers | ||
| assert result == ['TEST'] | ||
| @pytest.fixture | ||
| def layer_data(layer_density_factory, db_session): |
There was a problem hiding this comment.
Suggest of not re-using the same method name within a file and pick something unique (e.g. layer_data_with_density)
There was a problem hiding this comment.
Yeah I think that is a good call
micah-prime
reviewed
Nov 13, 2024
| ).set_crs("epsg:26912") | ||
| result = clz.from_area( | ||
| type="density", | ||
| shp=df.iloc[0].geometry, |
There was a problem hiding this comment.
I'm hesitant to lose these from_area tests, I think it is still important functionality to have safeguards around
There was a problem hiding this comment.
Nice catch. I think this test can be transferred over to the new structure.
|
This is looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #158
Updates test_layer_measurements.py following the new test infrastructure using factories.
Adds a new factory with real layer density data.
Showing progress so far to ensure I'm on the right track.