Merge pull request #399 from SockDrawer/fix-tests-unhandled-promises

Chores: Cleanup build/test warnings
SockDrawer · Dec 14, 2016 · 6a29d6e · 6a29d6e
2 parents c06ef05 + f7c6a67
commit 6a29d6e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/providers/nodebb/notification.js b/providers/nodebb/notification.js
@@ -425,7 +425,8 @@ exports.bindNotification = function bindNotification(forum) {
      * @private
      *
      * @param {*} notification Notification we are parsing
-     * @returns {Promise} Rejects with "Ignoring notification" if we do not process this. Resolves with the notification otherwise.
+     * @returns {Promise} Rejects with "Ignoring notification" if we do not process this. Resolves with the notification
+     * otherwise.
      */
     function evalBlacklist(notification) {
         return new Promise((resolve, reject) => {

diff --git a/test/lib/utilsTest.js b/test/lib/utilsTest.js
@@ -88,7 +88,7 @@ describe('lib/utils', () => {
         });
         it('should reject when iteration function rejects', () => {
             const spy = sinon.stub().rejects('bad');
-            return utils.iterate([0], spy).should.eventually.reject;
+            return utils.iterate([0], spy).should.be.rejectedWith('bad');
         });
     });
     describe('parseJSON()', () => {

diff --git a/test/providers/nodebb/formatTest.js b/test/providers/nodebb/formatTest.js
@@ -565,14 +565,16 @@ describe('providers/nodebb/format', () => {
                 [
                     undefined, null, false, '', 0, NaN, []
                 ].forEach((input) => {
-                    const expected = '<details>\n<summary>\nSPOILER!\n</summary>\n\nthey were dead all along\n\n</details>';
+                    const expected = '<details>\n<summary>\nSPOILER!\n</summary>\n\nthey were dead all along\n\n' +
+                        '</details>';
                     it(`should provide sensible output for input: ${input}`, () => {
                         const actual = testModule.spoiler('they were dead all along', input);
                         actual.should.equal(expected);
                     });
                 });
                 [
-                    ['Summer Glau', '<details>\n<summary>\nSummer Glau\n</summary>\n\nthey were dead all along\n\n</details>'],
+                    ['Summer Glau', '<details>\n<summary>\nSummer Glau\n</summary>\n\nthey were dead all along\n\n' +
+                        '</details>'],
                     [4, '<details>\n<summary>\n4\n</summary>\n\nthey were dead all along\n\n</details>'],
                     [3.1415, '<details>\n<summary>\n3.1415\n</summary>\n\nthey were dead all along\n\n</details>'],
                     [true, '<details>\n<summary>\ntrue\n</summary>\n\nthey were dead all along\n\n</details>'],

diff --git a/test/providers/nodebb/indexTest.js b/test/providers/nodebb/indexTest.js
@@ -343,7 +343,7 @@ describe('providers/nodebb', () => {
         });
         it('should reject on bad JSON response', () => {
             request.get.yields(null, null, '{"foo":"bar');
-            return forum._getConfig().should.reject;
+            return forum._getConfig().should.be.rejectedWith('Unexpected end of');
         });
     });
     describe('login()', () => {