Merge pull request #394 from SockDrawer/fix-matching-images

fix(Commands): Fix for images being seen as commands
SockDrawer · Dec 10, 2016 · 7b125d2 · 7b125d2
2 parents da730a6 + c9b6d25
commit 7b125d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/commands.js b/lib/commands.js
@@ -637,7 +637,7 @@ exports.bindCommands = function bindCommands(forum) {
             args.shift();
             commandText = args.shift();
             mention = true;
-        } else if (/^!\S{3,}(\s|$)/.test(line)) {
+        } else if (/^!\w\S{2,}(\s|$)/.test(line)) {
             args = line.split(/\s+/);
             commandText = args.shift().substring(1);
             mention = false;

diff --git a/test/lib/commandsTest.js b/test/lib/commandsTest.js
@@ -128,6 +128,9 @@ describe('lib/config', () => {
             it('should not match really short command', () => {
                 expect(parseLine('!c text stuff')).to.equal(null);
             });
+            it('should not match non-letters after !', () => {
+                expect(parseLine('![0_1481227127790_upload.png]')).to.equal(null);
+            });
             it('should match bare command', () => {
                 parseLine('!help').command.should.equal('help');
             });