-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postinstall script to install the safe npm alias #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@charliegerard This is an excellent idea! Should we also expose it in a CLI command, in case I deny it but want to do it later? Could be a command like |
philliprossii7
approved these changes
Jan 12, 2024
charliegerard
changed the title
Add postinstall script to install the safe npm alias
[WIP] Add postinstall script to install the safe npm alias
Jan 16, 2024
charliegerard
changed the title
[WIP] Add postinstall script to install the safe npm alias
Add postinstall script to install the safe npm alias
Jan 17, 2024
bmeck
reviewed
Jan 18, 2024
bmeck
reviewed
Jan 18, 2024
Implemented the feedback to replace |
bmeck
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds the following functionalities:
postinstall
script to ask users if they want to install our npm and npx wrapper so they're automatically protected against malicious packages. (It checks first if the aliases already exist and if so, does not prompt the user)socket wrapper
with the flags--enable
and--disable
if users want to add/remove the aliases later on. If the user enterssocket wrapper --enable
, the logic checks if the aliases are already set up and if so, lets the user know, otherwise adds the aliases in the bashrc or zshrc file.socket raw-npm
andsocket raw-npx
to temporarily bypass the wrapper.Flow:
~/.bashrc
or~/.zshrc
exist and if so, the aliases are added to this file and the following output is displayed.