Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General refactor: backend/frontend separation and API integration for ELF analysis #34

Merged
merged 12 commits into from
Jan 16, 2025

Conversation

giusbianco
Copy link
Collaborator

Pull Request Description

This pull request introduces a general refactor of the code, with a focus on improving the structure and clarity of the library through the following main interventions:

  1. Separation between backend and frontend:

    • The code has been reorganised to clearly distinguish backend functionality (processing, application logic) from frontend functionality (user interface).
    • Names and structures follow a more intuitive convention to reflect their purpose and role within the library.
  2. Integration of public APIs:

    • A practical example has been introduced, called behaviours-assessment, which uses the public APIs defined in the various library crates.
    • This example illustrates the use of the API to perform a static analysis of ELF binaries, showing how to integrate the main functionalities in a real context.
  3. General improvements:

    • Refactoring of code to improve readability and maintainability.
    • Migration of functionality to favour a modular and reusable structure.

@giusbianco giusbianco added the enhancement New feature or request label Jan 15, 2025
@giusbianco giusbianco requested a review from Luni-4 January 15, 2025 15:05
@giusbianco giusbianco self-assigned this Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your huge work! Just simple changes in the review comments

.gitattributes Outdated Show resolved Hide resolved
.github/workflows/heavy-tests.yml Outdated Show resolved Hide resolved
.github/workflows/heavy-tests.yml Show resolved Hide resolved
.github/workflows/manifest-producer.yml Outdated Show resolved Hide resolved
.github/workflows/manifest-producer.yml Outdated Show resolved Hide resolved
examples/behaviours_assessment/LICENSE Outdated Show resolved Hide resolved
examples/behaviours_assessment/src/main.rs Outdated Show resolved Hide resolved
examples/behaviours_assessment/Cargo.toml Outdated Show resolved Hide resolved
examples/behaviours_assessment/src/analysis.rs Outdated Show resolved Hide resolved
examples/behaviours_assessment/src/analysis.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last changes and then we can merge it

.github/workflows/heavy-tests.yml Outdated Show resolved Hide resolved
crates/frontend/src/error.rs Outdated Show resolved Hide resolved
.github/workflows/manifest-producer.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job! We can merge it!

@giusbianco giusbianco merged commit 80c76ce into main Jan 16, 2025
5 checks passed
@Luni-4 Luni-4 deleted the new-code branch January 16, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants