[MTM-58884] UI as datapoint graph user i want to see configured events and alarms #28

eniosultan · 2024-04-24T14:32:09Z

Proposed changes

Possibility to see configured events on the graph

TO DO:

Fix alarm/event icon coords when between 2 datapoints.
Show alarms/events in preview, currently the issue is that the config object has the wrong properties

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
Documentation Update (if none of the other choices apply)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA (in all commits with git commit -s)
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

#30) Co-authored-by: enio_sultan <ensu@softwareag.com>

…see-configured-events' of github.com:SoftwareAG/cumulocity-community-plugins into feature/MTM-58884-ui-as-datapoint-graph-user-i-want-to-see-configured-events

jdre-c8y

part 1/2

src/datapoints-graph/charts/chart-realtime.service.ts

src/datapoints-graph/charts/chart.model.ts

src/datapoints-graph/charts/charts.component.ts

jdre-c8y

2/2

src/datapoints-graph/alarm-event-selector/alarm-event-selector.model.ts

src/datapoints-graph/charts/echarts-options.service.ts

src/datapoints-graph/datapoints-graph-view/chart-alarms.service.ts

src/datapoints-graph/datapoints-graph-view/chart-events.service.ts

src/datapoints-graph/datapoints-graph-view/datapoints-graph-widget-view.component.ts

src/datapoints-graph/charts/chart-realtime.service.ts

src/datapoints-graph/charts/chart.model.ts

src/datapoints-graph/charts/echarts-options.service.ts

src/datapoints-graph/datapoints-graph-view/chart-alarms.service.ts

src/datapoints-graph/datapoints-graph-view/chart-events.service.ts

Co-authored-by: jdreSAG <103751383+jdreSAG@users.noreply.github.com> Signed-off-by: Enio Sultan <92023325+eniosultan@users.noreply.github.com>

jdre-c8y

code looks good, still needs tests though

src/datapoints-graph/charts/chart-realtime.service.ts

src/datapoints-graph/charts/echarts-options.service.ts

src/datapoints-graph/model/datapoints-graph-widget.model.ts

eniosultan · 2024-06-05T09:34:55Z

code looks good, still needs tests though

@jdreSAG I wanted to add tests after the first approval

src/datapoints-graph/charts/chart-realtime.service.ts

src/datapoints-graph/charts/chart.model.ts

src/datapoints-graph/charts/charts.component.ts

src/datapoints-graph/datapoints-graph-view/chart-alarms.service.ts

src/datapoints-graph/datapoints-graph-view/chart-events.service.ts

src/datapoints-graph/datapoints-graph-view/chart-alarms.service.ts

src/datapoints-graph/datapoints-graph-view/datapoints-graph-widget-view.component.ts

…see-configured-events' of https://github.com/SoftwareAG/cumulocity-community-plugins into feature/MTM-58884-ui-as-datapoint-graph-user-i-want-to-see-configured-events

src/datapoints-graph/charts/chart-realtime.service.ts

src/datapoints-graph/charts/chart.model.ts

src/datapoints-graph/model/datapoints-graph-widget.model.ts

tsconfig.json

Enio Sultan and others added 4 commits April 18, 2024 18:14

MTM-58884 Initial commit.

9b67cf0

MTM-58884 Events are now displayed. You can show/hide them in legend

90abdd0

MTM-58884 added chart legend and event data on hover of markedLine

46eae2b

MTM-58884 Added realtime support for events and general improvements.

24debe8

jdre-c8y mentioned this pull request May 10, 2024

feat(datapoints-graph): [MTM-52605] Configure alarms and events in Data points graph 2.0 and display on chart #29

Merged

19 tasks

[MTM-58885] UI as datapoint graph user i want to see configured alarms (

0388885

#30) Co-authored-by: enio_sultan <ensu@softwareag.com>

eniosultan changed the base branch from main to feat/MTM-52605-alarm-and-event-in-data-points-graph-2 May 13, 2024 18:55

MTM-58884 Legend re-work initial commit.

034c3a3

jdre-c8y mentioned this pull request May 16, 2024

feat(datapoints-graph): alarm event selector list for Data points graph 2.0 #27

Merged

9 tasks

Enio Sultan and others added 7 commits May 16, 2024 18:00

MTM-58884 Added new legend and all-around fixes.

9fbab27

MTM-58884 Hover improvements + general fixes.

2ee9e61

feat: improve datapoints graph widget styling

d5e10ed

MTM-58884 Fixed issues with sticky tooltip when we enable marked area

40d8f11

Merge branch 'feature/MTM-58884-ui-as-datapoint-graph-user-i-want-to-…

c51cc1e

…see-configured-events' of github.com:SoftwareAG/cumulocity-community-plugins into feature/MTM-58884-ui-as-datapoint-graph-user-i-want-to-see-configured-events

Merge event-alarm selector

aa3676d

MTM-58884 Updates after merging event-alarm selector + refactoring

1b2d013

eniosultan marked this pull request as ready for review May 25, 2024 10:40

eniosultan requested a review from jdre-c8y May 25, 2024 10:41

eniosultan changed the title ~~[MTM-58884] UI as datapoint graph user i want to see configured events~~ [MTM-58884] UI as datapoint graph user i want to see configured events and alarms May 25, 2024

eniosultan changed the base branch from feat/MTM-52605-alarm-and-event-in-data-points-graph-2 to feat/MTM-58883-alarm-and-event-selector May 27, 2024 08:31

jdre-c8y reviewed May 27, 2024

View reviewed changes

Base automatically changed from feat/MTM-58883-alarm-and-event-selector to feat/MTM-52605-alarm-and-event-in-data-points-graph-2 May 28, 2024 10:21

Enio Sultan and others added 3 commits May 28, 2024 16:56

MTM-58884 Updates after review part 1

c5574ee

MTM-58884 Updates after review and refactor part 2.

56d26a7

MTM-58884 Refactoring and changes after review final part 3

ed28ead

jdre-c8y reviewed Jun 3, 2024

View reviewed changes

eniosultan and others added 2 commits June 3, 2024 12:08

Apply suggestions from code review

616cbf7

Co-authored-by: jdreSAG <103751383+jdreSAG@users.noreply.github.com> Signed-off-by: Enio Sultan <92023325+eniosultan@users.noreply.github.com>

MTM-58884 Refactoring and improvements after 2nd round of review.

dac1c7b

eniosultan requested a review from jdre-c8y June 3, 2024 13:14

jdre-c8y reviewed Jun 5, 2024

View reviewed changes

MTM-58884 Changes after review.

4e65513

eniosultan requested a review from jdre-c8y June 5, 2024 09:41

jdre-c8y approved these changes Jun 5, 2024

View reviewed changes

MTM-58884 Realtime fix and partial unit test updates...

bed401a

DawidSAG reviewed Jun 12, 2024

View reviewed changes

Enio Sultan and others added 3 commits June 13, 2024 17:20

MTM-58884 Initial commit with severity filters.

c1160f3

Merge branch 'feature/MTM-58884-ui-as-datapoint-graph-user-i-want-to-…

d13ceb5

…see-configured-events' of https://github.com/SoftwareAG/cumulocity-community-plugins into feature/MTM-58884-ui-as-datapoint-graph-user-i-want-to-see-configured-events

MTM-58884 Changes after review.

f359212

eniosultan requested a review from DawidSAG June 14, 2024 13:23

DawidSAG reviewed Jun 20, 2024

View reviewed changes

MTM-58884 Realtime refactor and changes after review.

224f1e5

eniosultan requested a review from DawidSAG June 21, 2024 07:49

Enio Sultan added 2 commits June 21, 2024 15:09

MTM-58884 FIxed issue with duplicated event id's

ddbdcaf

MTM-58884 Fixes after review.

fea9991

DawidSAG approved these changes Jun 21, 2024

View reviewed changes

eniosultan merged commit 33b9e99 into feat/MTM-52605-alarm-and-event-in-data-points-graph-2 Jun 21, 2024
1 check failed

eniosultan deleted the feature/MTM-58884-ui-as-datapoint-graph-user-i-want-to-see-configured-events branch June 21, 2024 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MTM-58884] UI as datapoint graph user i want to see configured events and alarms #28

[MTM-58884] UI as datapoint graph user i want to see configured events and alarms #28

eniosultan commented Apr 24, 2024 •

edited

Loading

jdre-c8y left a comment

jdre-c8y left a comment

jdre-c8y left a comment

eniosultan commented Jun 5, 2024

[MTM-58884] UI as datapoint graph user i want to see configured events and alarms #28

[MTM-58884] UI as datapoint graph user i want to see configured events and alarms #28

Conversation

eniosultan commented Apr 24, 2024 • edited Loading

Proposed changes

TO DO:

Types of changes

Paste Link to the issue

Checklist

jdre-c8y left a comment

Choose a reason for hiding this comment

jdre-c8y left a comment

Choose a reason for hiding this comment

jdre-c8y left a comment

Choose a reason for hiding this comment

eniosultan commented Jun 5, 2024

eniosultan commented Apr 24, 2024 •

edited

Loading