DATAGO-85698: Jira tickets should be created from C-EMA error logs #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CameronRushton
temporarily deployed
to
build_pr
GitHub Actions
Inactive
CameronRushton
temporarily deployed
to
build_pr
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
| @@ -26,7 +26,7 @@ | |||
| <if condition='property("USE_JSON").equals("true")'> | |||
| <then> | |||
| <encoder class="net.logstash.logback.encoder.LogstashEncoder"> | |||
| <customFields>{"component":"event-management-agent-${agentId}"}</customFields> | |||
| <customFields>{"component":"event-management-agent-${agentId}", "ema_id":"${agentId}"}</customFields> | |||
There was a problem hiding this comment.
Since the agentId is already mentioned in the component value, can we use that value instead?
Merging this change would mean, releasing a new EMA after running tests, updating all production C-EMAs. So it would be great if we can use the existing value from component instead.
There was a problem hiding this comment.
We absolutely can. That would have saved me a lot of time. I'll edit and re-test the monitor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Add the CEMA ID to the logs so that it shows up in our monitoring
How was this change implemented?
Add the EMA ID to MDC
How was this change tested?
Deploying a copy of the EMA and testing the monitor in dev
Is there anything the reviewers should focus on/be aware of?
None