Reconfigure header info during collapseAdats() #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stufield
force-pushed
the
fix-header-platescale-collapse
branch
from
fb5693f
to
c4b21b4
Compare
- `collapseAdats()` now does a better job of
maintaining useful information when combining
ADATs during the collapse
- `PlateScale*` and `Cal*` information is now
merged, rather than concatenated, resulting
in shorter set of attributes
- new values in downstream ADATs are maintained, and no longer lost when written
- the majority of HEADER information is still
that of the first, initial ADAT in the list
- the `stopifnot()` call gets more clear error message
- closes SomaLogic#86
stufield
force-pushed
the
fix-header-platescale-collapse
branch
from
c4b21b4
to
8b15b9e
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 75.51% 75.71% +0.19%
==========================================
Files 42 42
Lines 1491 1507 +16
==========================================
+ Hits 1126 1141 +15
- Misses 365 366 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
collapseAdats()now does a better job of maintaining useful information when combining ADATs during the collapseHEADERinformation is still that of the first, initial ADAT in the liststopifnot()call gets more clear error message