Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed backlink to SonarQube in new JIRA issues #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed backlink to SonarQube in new JIRA issues #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16d3f66
Fixed URL for issue creation
racing4valor Mar 22, 2016
cd1bfaa
Fixed unit tests to expect new URL format
racing4valor Mar 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/sonar/plugins/jira/reviews/JiraIssueCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ protected String generateIssueDescription(Issue sonarIssue, Settings settings) {
description.append(QUOTE);
description.append("\n\nCheck it on SonarQube: ");
description.append(settings.getString(CoreProperties.SERVER_BASE_URL));
description.append("/issue/show/");
description.append("/issues/show/");
description.append(sonarIssue.key());
return description.toString();
}
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/org/sonar/plugins/jira/reviews/JiraIssueCreatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public void shouldInitRemoteIssue() throws Exception {
expectedIssue.setPriority("4");
expectedIssue.setSummary("SonarQube Issue #ABCD - Avoid cycle between java packages");
expectedIssue.setDescription("Issue detail:\n{quote}\nThe Cyclomatic Complexity of this method is 14 which is greater than 10 authorized.\n" +
"{quote}\n\n\nCheck it on SonarQube: http://my.sonar.com/issue/show/ABCD");
"{quote}\n\n\nCheck it on SonarQube: http://my.sonar.com/issues/show/ABCD");

// Verify
RemoteIssue returnedIssue = jiraIssueCreator.initRemoteIssue(sonarIssue, settings);
Expand All @@ -198,7 +198,7 @@ public void shouldInitRemoteIssueWithTaskType() throws Exception {
expectedIssue.setPriority("4");
expectedIssue.setSummary("SonarQube Issue #ABCD - Avoid cycle between java packages");
expectedIssue.setDescription("Issue detail:\n{quote}\nThe Cyclomatic Complexity of this method is 14 which is greater than 10 authorized.\n" +
"{quote}\n\n\nCheck it on SonarQube: http://my.sonar.com/issue/show/ABCD");
"{quote}\n\n\nCheck it on SonarQube: http://my.sonar.com/issues/show/ABCD");

// Verify
RemoteIssue returnedIssue = jiraIssueCreator.initRemoteIssue(sonarIssue, settings);
Expand All @@ -218,7 +218,7 @@ public void shouldInitRemoteIssueWithComponent() throws Exception {
expectedIssue.setPriority("4");
expectedIssue.setSummary("SonarQube Issue #ABCD - Avoid cycle between java packages");
expectedIssue.setDescription("Issue detail:\n{quote}\nThe Cyclomatic Complexity of this method is 14 which is greater than 10 authorized.\n" +
"{quote}\n\n\nCheck it on SonarQube: http://my.sonar.com/issue/show/ABCD");
"{quote}\n\n\nCheck it on SonarQube: http://my.sonar.com/issues/show/ABCD");
expectedIssue.setComponents(new RemoteComponent[] {new RemoteComponent("123", null)});

// Verify
Expand Down Expand Up @@ -247,7 +247,7 @@ public void shouldInitRemoteIssueWithoutName() throws Exception {
expectedIssue.setPriority("4");
expectedIssue.setSummary("SonarQube Issue #ABCD");
expectedIssue.setDescription("Issue detail:\n{quote}\nThe Cyclomatic Complexity of this method is 14 which is greater than 10 authorized.\n" +
"{quote}\n\n\nCheck it on SonarQube: http://my.sonar.com/issue/show/ABCD");
"{quote}\n\n\nCheck it on SonarQube: http://my.sonar.com/issues/show/ABCD");

// Verify
RemoteIssue returnedIssue = jiraIssueCreator.initRemoteIssue(sonarIssue, settings);
Expand Down