Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONAR-20383 Fix flaky issue on docker buildx #647

Merged
merged 1 commit into from
Sep 28, 2023
Merged

SONAR-20383 Fix flaky issue on docker buildx #647

merged 1 commit into from
Sep 28, 2023

Conversation

carminevassallo
Copy link
Contributor

No description provided.

@steve-marion-sonarsource
Copy link
Contributor

The commit should be marked with DO NOT MERGE or WIP in it so that there is no way it can be merged.

@carminevassallo
Copy link
Contributor Author

It's not ready for review yet. I'll request your review, @steve-marion-sonarsource when ready.

@carminevassallo carminevassallo force-pushed the task/cv/SONAR-20383-fix-failure-in-docker-sonarqube-multi-arch-build-step-context-deadline-exceeded branch 2 times, most recently from 339cf32 to 67ae105 Compare September 27, 2023 13:12
jCOTINEAU
jCOTINEAU approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@jCOTINEAU jCOTINEAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

Added a small comment about reducing the complexity of the script, not preventing from merging in my opinion

.cirrus/multi-arch-build.sh Show resolved Hide resolved
@carminevassallo carminevassallo force-pushed the task/cv/SONAR-20383-fix-failure-in-docker-sonarqube-multi-arch-build-step-context-deadline-exceeded branch from 67ae105 to 3b1492e Compare September 27, 2023 13:55
@carminevassallo carminevassallo enabled auto-merge (squash) September 27, 2023 14:59
@carminevassallo carminevassallo force-pushed the task/cv/SONAR-20383-fix-failure-in-docker-sonarqube-multi-arch-build-step-context-deadline-exceeded branch from 3b1492e to 11525c6 Compare September 28, 2023 06:04
@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@carminevassallo carminevassallo enabled auto-merge (squash) September 28, 2023 07:01
@carminevassallo carminevassallo merged commit 7a88eaf into master Sep 28, 2023
31 checks passed
@carminevassallo carminevassallo deleted the task/cv/SONAR-20383-fix-failure-in-docker-sonarqube-multi-arch-build-step-context-deadline-exceeded branch September 28, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jCOTINEAU jCOTINEAU jCOTINEAU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carminevassallo @steve-marion-sonarsource @jCOTINEAU