SONAR-20590 - Adds retry mechanism for public and private scan tasks #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-jarocki-sonarsource
requested review from
carminevassallo
and removed request for
lukasz-jarocki-sonarsource
carminevassallo
requested changes
Oct 6, 2023
There was a problem hiding this comment.
Hi @davividal,
great PR, the script is super easy to read.
I think we can still optimize it a bit. WDYT?
- The two scripts are almost equal. We can easily refactor and extract some variables to have only one script for both CI steps.
- The issue was only about docker pull[ing] from DockerHub. I propose we remove the retry of the scan on Mend, as we never face issues there.
carminevassallo
force-pushed
the
dkv/SONAR-20590-adds-retry-to-scan-tasks
branch
from
7978d6c
to
16dd63d
Compare
|
SonarQube Quality Gate
|
carminevassallo
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.