Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAR-22581 docker image openshift hardening #695

Merged

Conversation

jCOTINEAU
Copy link
Contributor

No description provided.

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-22581-docker-image-openshift-hardening branch from 0147851 to e79a7df Compare July 24, 2024 14:23
Copy link
Contributor

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jeremy,

great job! I was mentioning a few things in my review, could you please have a look and tell me what you think?

Furthermore, the sq-dce-postgres compose file does not work. I get several directories that cannot be created (I'm using images built after your changes). Could you please up this docker compose and tell me if you get similar errors?

10/community/Dockerfile Show resolved Hide resolved
10/community/Dockerfile Show resolved Hide resolved
@jCOTINEAU
Copy link
Contributor Author

Hi Jeremy,

great job! I was mentioning a few things in my review, could you please have a look and tell me what you think?

Furthermore, the sq-dce-postgres compose file does not work. I get several directories that cannot be created (I'm using images built after your changes). Could you please up this docker compose and tell me if you get similar errors?

Well it is weird, I have been testing only with this docker-compose file and the new images, let me double check this.

@jCOTINEAU
Copy link
Contributor Author

Hi Jeremy,
great job! I was mentioning a few things in my review, could you please have a look and tell me what you think?
Furthermore, the sq-dce-postgres compose file does not work. I get several directories that cannot be created (I'm using images built after your changes). Could you please up this docker compose and tell me if you get similar errors?

Well it is weird, I have been testing only with this docker-compose file and the new images, let me double check this.

Right some issues were happening on the app nodes, missed that during the tests, fixed

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-22581-docker-image-openshift-hardening branch from 7ce6b5d to cb2b227 Compare July 25, 2024 12:41
Copy link
Contributor

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small other requests

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-22581-docker-image-openshift-hardening branch from cb2b227 to 78a76a2 Compare July 25, 2024 15:07
@jCOTINEAU jCOTINEAU enabled auto-merge (squash) July 25, 2024 15:43
Copy link

@jCOTINEAU jCOTINEAU merged commit e31e0be into master Jul 25, 2024
31 checks passed
@jCOTINEAU jCOTINEAU deleted the feature/jc/SONAR-22581-docker-image-openshift-hardening branch July 25, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants