Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPHP-1522 Migrate ruleApi to Gradle #1296

Merged
merged 3 commits into from
Nov 5, 2024
Merged

SONARPHP-1522 Migrate ruleApi to Gradle #1296

merged 3 commits into from
Nov 5, 2024

Conversation

GabinL21
Copy link
Contributor

@GabinL21 GabinL21 commented Nov 4, 2024

@GabinL21 GabinL21 self-assigned this Nov 4, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put everything in this file instead of having a RuleApiUpdateConfiguration.kt like in IaC and Text because:

  • We only have 2 tasks to register, so it looks like useless complexity.
  • We don't need to worry about parallel execution since we only have one rule repository (PHP), we will never run multiple Rule API updates at the same time.

Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqube-next bot commented Nov 5, 2024

@GabinL21 GabinL21 merged commit b6e30f6 into master Nov 5, 2024
15 of 16 checks passed
@GabinL21 GabinL21 deleted the SONARPHP-1522 branch November 5, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants