Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1556 Detects hard-coded secrets for different AST elements #1297

Merged
merged 3 commits into from
Nov 7, 2024
Merged

SONARPHP-1556 Detects hard-coded secrets for different AST elements #1297

merged 3 commits into from
Nov 7, 2024

Conversation

mstachniuk
Copy link
Contributor

@mstachniuk mstachniuk commented Nov 5, 2024 •
edited by jira bot
Loading

@mstachniuk mstachniuk mentioned this pull request Nov 5, 2024
Closed
rudy-regazzoni-sonarsource
rudy-regazzoni-sonarsource approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job! Please see my few comments.

php-checks/src/main/java/org/sonar/php/checks/HardCodedSecretCheck.java Outdated Show resolved Hide resolved
php-checks/src/main/java/org/sonar/php/checks/HardCodedSecretCheck.java Outdated Show resolved Hide resolved
php-checks/src/main/java/org/sonar/php/checks/HardCodedSecretCheck.java Outdated Show resolved Hide resolved
php-checks/src/test/resources/checks/HardCodedSecretCheckAST.php Show resolved Hide resolved
php-checks/src/test/resources/checks/HardCodedSecretCheckAST.php Show resolved Hide resolved
php-checks/src/test/resources/checks/HardCodedSecretCheckAST.php Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 7, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
6 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@mstachniuk mstachniuk merged commit 873f46a into master Nov 7, 2024
16 checks passed
@mstachniuk mstachniuk deleted the SONARPHP-1556 branch November 7, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstachniuk @rudy-regazzoni-sonarsource