SONARPHP-1562 Add basic support for PropertyHooks #1302
Conversation
jonas-wielage-sonarsource
force-pushed
the
SONARPHP-1562
branch
6 times, most recently
from
7575917
to
84f1e61
Compare
jonas-wielage-sonarsource
force-pushed
the
SONARPHP-1562
branch
from
84f1e61
to
49d4642
Compare
| b.zeroOrMore(ATTRIBUTE_GROUP()), | ||
| b.zeroOrMore(MEMBER_MODIFIER()), | ||
| b.optional(b.token(PHPPunctuator.AMPERSAND)), | ||
| NAME_IDENTIFIER_OR_KEYWORD(), |
There was a problem hiding this comment.
Instead of allowing any string here, couldn't we explicitly only allow get or set, with possibly enum values in the AST?
There was a problem hiding this comment.
I tried to do it by adding it to PHPKeywordsbut this will conflict the parser when other method declarations try to declare getor setmethods.
If you know another way, I'm happy to change it
There was a problem hiding this comment.
Found one!
php-frontend/src/main/java/org/sonar/php/tree/impl/declaration/PropertyHookListTreeImpl.java
Outdated
Show resolved
Hide resolved
...tend/src/main/java/org/sonar/php/tree/impl/declaration/ClassPropertyDeclarationTreeImpl.java
Show resolved
Hide resolved
| if (!"get".equals(name.text()) && !"set".equals(name.text())) { | ||
| throw new RecognitionException(((PHPTree) name).getLine(), "Declared property hook must be named \"get\" or \"set\""); | ||
| } |
There was a problem hiding this comment.
It seems strange to me to have part of the grammar logic in the TreeFactory class. As mentioned above I would strictly match get/set in the grammar and not grab any word.
There was a problem hiding this comment.
I agree, but didn't find a good way to do it. I May try again.
There was a problem hiding this comment.
Found one!
php-frontend/src/main/java/org/sonar/php/parser/PHPGrammar.java
Outdated
Show resolved
Hide resolved
php-frontend/src/main/java/org/sonar/php/parser/PHPGrammar.java
Outdated
Show resolved
Hide resolved
|
SONARPHP-1562
Part of