Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1520 Migrate Custom Rules module to Gradle #1305

Merged
merged 13 commits into from
Nov 10, 2024
Merged

SONARPHP-1520 Migrate Custom Rules module to Gradle #1305

merged 13 commits into from
Nov 10, 2024

Conversation

GabinL21
Copy link
Contributor

@GabinL21 GabinL21 commented Nov 7, 2024 •
edited by jira bot
Loading

@GabinL21 GabinL21 self-assigned this Nov 7, 2024
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title SONARPHP-1520 Migrate Custom Rules module to Gradle SONARPHP-1520 Migrate Custom Rules module to Gradle Nov 7, 2024
mstachniuk
mstachniuk requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, please see my comments

.cirrus/modules/build.star Show resolved Hide resolved
php-custom-rules/build.gradle.kts Outdated Show resolved Hide resolved
its/plugin/tests/build.gradle.kts Outdated Show resolved Hide resolved
sonar-php-plugin/build.gradle.kts Show resolved Hide resolved
mstachniuk
mstachniuk approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@GabinL21 GabinL21 merged commit 237e402 into master Nov 10, 2024
17 checks passed
@GabinL21 GabinL21 deleted the SONARPHP-1520 branch November 10, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstachniuk mstachniuk mstachniuk approved these changes

Assignees

@GabinL21 GabinL21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabinL21 @mstachniuk