Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1466 Replace nested classes in it-php-plugin-tests:Tests with a more elegant solution #1312

Closed
wants to merge 1 commit into from
Closed

SONARPHP-1466 Replace nested classes in it-php-plugin-tests:Tests with a more elegant solution #1312

wants to merge 1 commit into from

Conversation

GabinL21
Copy link
Contributor

@GabinL21 GabinL21 commented Nov 10, 2024 •
edited by jira bot
Loading

@GabinL21 GabinL21 self-assigned this Nov 10, 2024
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

rudy-regazzoni-sonarsource
rudy-regazzoni-sonarsource reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks far better from my perspective, but It seems to currently have a significant impact on the feedback loop delay. We can discuss about it.

.cirrus/modules/qa.star Show resolved Hide resolved
its/plugin/tests/src/integrationTest/java/com/sonar/it/php/OrchestratorTest.java Show resolved Hide resolved
@GabinL21 GabinL21 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource left review comments

Assignees

@GabinL21 GabinL21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabinL21 @rudy-regazzoni-sonarsource