SLOMNI-25 Use path to analyzer JAR provided through analyzer property #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblievremont
force-pushed
the
SLOMNI-25-configure-path-to-jar
branch
from
4cc3c0d
to
176c076
Compare
| @@ -79,6 +79,7 @@ public void execute(SensorContext context) { | |||
| return; | |||
| } | |||
| try { | |||
| Path analyzerPluginPath = context.config().get(CSharpPropertyDefinitions.getEnterpriseAnalyzerPath()).map(Paths::get).orElse(null); | |||
There was a problem hiding this comment.
We can check the additional analyzer property value (sonar.omnisharp.internal.shouldUseEnterprise or similar) and decide which analyzer plugin path to use - OSS or enterprise
| var analyzerPluginPath = configuration.get(CSharpPropertyDefinitions.getEnterpriseAnalyzerPath()).orElse(null); | ||
| try (InputStream analyzerPlugin = new FileInputStream(analyzerPluginPath)) { | ||
| requireNonNull(analyzerPlugin, "Plugin jar not found"); | ||
| ZipUtils.unzip(analyzerPlugin, pluginUnzipDir, ze -> ze.getName().endsWith(".zip") || ze.getName().endsWith(".json") || ze.getName().endsWith(".html")); |
There was a problem hiding this comment.
No need to filter the components anymore, analyzer should do it.
There was a problem hiding this comment.
Is this filtering still needed?
jblievremont
force-pushed
the
SLOMNI-25-configure-path-to-jar
branch
from
c5f688b
to
548cc65
Compare
jblievremont
force-pushed
the
SLOMNI-25-configure-path-to-jar
branch
from
f6ec1a3
to
51f6b98
Compare
sophio-japharidze-sonarsource
approved these changes
Nov 7, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLOMNI-25