-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
123 mac m1 installation #164
Conversation
…ls from git. Version control on some dependcies are modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@armantekinalp please take a look again and merge accordingly. |
I think this is not working yet. Songyuan was planning to test on different machines. @sy-cui can you confirm? |
After the most recent push everything should be fine now. I have tested on Bridges and Expanse and they install without issue. We could (and should) let people in the lab try installing now because I made the dependency sources platform dependent, and we might not catch some issues with just clusters. |
Okay let me try on my system as well, then we can proceed |
@sy-cui and @armantekinalp current installation instructions on this branch didnt work on my machine (pyfftw issue I think): |
ok I just realized the issue. The install instructions don't tell to install Also we need instructions to install basically current instructions dont work off the bat, some more details are needed |
@armantekinalp @bhosale2 can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #123
The source of dependencies
PyFFTW
andpystencils
are set to two temporary git repositories.PyFFTW
: https://github.com/tp5uiuc/pyFFTW/tree/macos_fixpystencils
: https://github.com/sy-cui/pystencils/tree/macos_fixThe modifed
PyFFTW
looks upfftw
library in/opt/homebrew/lib
on macos platforms.In
pystencils
, the shared object (.so) file is not dynamically linked toOpenMP
properly on Apple M1. Restricting the-fopenmp
compiler option to the linking stage alone seems to resolve this issue. For our purpose, it is also plausible to compile in one step instead of twobut we don't do it for now.
A new
environment.yml
file is provided to integrate poetry into conda environment.(curtesy of https://stackoverflow.com/questions/70851048/does-it-make-sense-to-use-conda-poetry)
Poetry version is restricted to below 1.6 to avoid a known issue with version control.
Edit:
The changes regarding
-fopenmp
on pystencils is reverted as multithreading isn't enabled if the flag isn't passed. Instead the clang compiler flag-Xclang
is removed as it prevents-fopenmp
from being recognized as a regular command line option.