add support for jsonb fields #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@madhums Could you please add a spec for this case? |
|
Do you think this could be useful? On a second thought, I can expose some of the fields through model attributes without exporting the json field itself. So I am considering closing this. |
| @@ -52,6 +52,8 @@ def record_attribute(record, attribute_key, attribute_type) | |||
| field.truncate | |||
| when Administrate::Field::Time.to_s | |||
| field.data.strftime("%I:%M%p").to_s if field.data | |||
| when Administrate::Field::JSONB.to_s | |||
| field.to_json | |||
| else | |||
| field.to_s | |||
There was a problem hiding this comment.
Does field.to_s below produce the same output?
There was a problem hiding this comment.
No, I get an Administrate object.
There was a problem hiding this comment.
Then this fix would make sense to me. Would this need to be included as a dependency?
There was a problem hiding this comment.
Then I'm not sure it makes sense to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.