Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define a more robust asset schema and expose media assets on thread/post APIs #20

Merged
merged 5 commits into from
Jul 23, 2023

Conversation

Southclaws
Copy link
Owner

@Southclaws Southclaws commented Jul 14, 2023

still todo:

Update the thread reply box so it supports image uploads also as well as draft states and think about draft replies a bit more.

notes:

  • a thread can have a single draft reply from each user
  • a thread cannot have multiple draft replies from a single user - this feels weird and difficult to express well, also no use-case for drafting more than 1 reply to a thread
  • when a thread page loads, API must determine that if the request was made by a logged-in user, whether that user has an unsent draft reply to the thread and return it with the payload
  • but what does that look like API-side? simply include it in the posts list or explicitly separate this into a draft_reply/unsent_reply so it's clearer that this is a single piece of data separate from the thread list (feels cleaner)
  • ReplyBox needs to behave pretty much the same as ComposeScreen so, other than the layout, these should behave the same and probably be abstracted into a separate component
  • should ContentComposer be this abstraction? Or is there another layer that should exist between that handles the wiring together of posts and assets (as well as deletion). If this is the right path forward, then it needs to not touch redirects and instead provide a way for ComposeScreen to determine what happens when a brand new draft is created (redirect to /new?id=xyz)

@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storyden ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2023 6:15pm
storyden-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2023 6:15pm

…replies and linking assets to sub-posts for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant