Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Confirmation Dialog when Adding Duplicate Combo #398

Open
GordonsKitchen opened this issue Apr 22, 2024 · 1 comment
Open

Add Confirmation Dialog when Adding Duplicate Combo #398

GordonsKitchen opened this issue Apr 22, 2024 · 1 comment
Labels
cumbersome The implementations seems to get cumbersome enhancement New feature or request

Comments

@GordonsKitchen
Copy link
Collaborator

It would be good to have a confirmation dialog pop up when an editor tries to add a combo that is a duplicate of a pre-existing combo. I was thinking of something similar to the dialog that pops up when you delete a combo. A message like "The combo you are trying to add is a duplicate of combo [ID]. Would you still like to add this combo?" and then a yes/no answer. Yes adds the combo as normal, no takes you back to the "Add Combo" screen.

I think this would be good to have to ward out accidental duplicates before they are added and then (likely) need deleted. If we do need to have duplicates for some reason, we can still do so.

@GordonsKitchen GordonsKitchen added the enhancement New feature or request label Apr 22, 2024
@ldeluigi
Copy link
Member

Today I tried working on this request without exploiting third party software, and I concluded that it costs too much dev efforts and time to get it done well. Django, the framework powering the backend, doesn't allow easy customization to implement a confirmation page that conditionally pops out based on related objects such as cards, templates and features in a combo, which need to be inspected in order to detect any duplicate.

@ldeluigi ldeluigi added the cumbersome The implementations seems to get cumbersome label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cumbersome The implementations seems to get cumbersome enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants