Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Generator Combos to Have 1+ Produced Feature(s) #508

Open
GordonsKitchen opened this issue Aug 10, 2024 · 1 comment
Open

Force Generator Combos to Have 1+ Produced Feature(s) #508

GordonsKitchen opened this issue Aug 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@GordonsKitchen
Copy link
Collaborator

image

The backend currently allows generator combos to not have a listed produced feature. Generator combos will always need to have 1+ produced feature(s). I do not want to force all combos to have one listed, because of drafts and utilities that don't always need them.

@GordonsKitchen GordonsKitchen added the enhancement New feature or request label Aug 10, 2024
@ldeluigi
Copy link
Member

ldeluigi commented Oct 1, 2024

The fact that generator combos must have a result is an editor convention, but in theory a generator combos could be composed of a set of features that alone are sufficient to generate variants with all the necessary results, without adding a new one on top.

In addition, I can't implement this feature because Django unfortunately does not allow to cross-check fields of a Combo (in this case the kind) together with the related entities (in this case the produced features).

If you agree I'd like to close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants