Develop chip #2337

pethel · 2024-10-01T13:09:17Z

Har dialog med Sindre om feks dom ikonerna trenger en label eller noe. Det var noen kontrastissues men det kan vi jsutera eftervart. Jag har også freestylat onColoredBg

pethel · 2024-10-01T13:14:24Z

.storybook/main.less

-@import '@sb1/ffe-spinner/less/spinner';
-@import '@sb1/ffe-tables/less/tables';
-@import '@sb1/ffe-tabs/less/tabs';
+@import '../packages/ffe-core/less/ffe';


<Det blir mer riktigt slik.. grunden til att dom andre funker er fordi dom er i node_modules pga av component-overview

github-actions · 2024-10-01T13:14:31Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

github-actions · 2024-10-01T13:16:49Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

pethel · 2024-10-01T13:17:14Z

packages/ffe-chips-react/src/Chip.tsx

+const closeOpen400Sm =
+    'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGhlaWdodD0iMjAiIHZpZXdCb3g9IjAgLTk2MCA5NjAgOTYwIiB3aWR0aD0iMjAiPjxwYXRoIGQ9Im0zODktMzY5IDI5OS0yOTlxMTAuOTA5LTExIDI1LjQ1NS0xMVE3MjgtNjc5IDczOS02NjhxMTEgMTEgMTEgMjUuNTgyIDAgMTQuNTgzLTEwLjYwNyAyNS4xODhMNDE1LTI5MnEtMTAuOTA5IDExLTI1LjQ1NSAxMVEzNzUtMjgxIDM2NC0yOTJMMjIxLTQzNXEtMTEtMTEtMTEtMjUuNXQxMS0yNS41cTExLTExIDI1LjY2Ny0xMSAxNC42NjYgMCAyNS4zMzMgMTFsMTE3IDExN1oiLz48L3N2Zz4=';
+
+const checkOpen400Sm =


Jag gjorde slik fordi vi vet ikke hvordna apparna laster svg ? att jest ikke liker svger.. .i så fall må vi finna det en måte att gjøra det på tvers av alla appar men det kan vi sikkert se på sedan. Det er ju en felles config.

pethel · 2024-10-01T13:18:04Z

packages/ffe-chips-react/src/ChipBase.tsx

+        isSelected?: boolean;
+    };
+
+function ChipBaseWithForwardRef<As extends ElementType>(


Jag lagde en ChipBase hvis vi skall lage flere typer Chip eller noen har annen har lust på den.

pethel · 2024-10-01T13:18:35Z

packages/ffe-chips/less/chip.less

+    --border-radius: 24px;
+    --border-color: var(--ffe-v-chip-border-color);
+    --text-color: var(--ffe-v-chip-text-color);
+    --text-offset: 12px;


12 er vell en multiple av 8 kanskje.. det var i skisserna iaf

github-actions · 2024-10-01T13:20:25Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

github-actions · 2024-10-01T13:21:06Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

tuva-odegard · 2024-10-01T13:26:58Z

Hvordan kan vi sjekke at det fungerer på stagingsiden? Siden det ikke er laget eksempler fordi den er laget med storybook

pethel · 2024-10-01T13:30:34Z

Hvordan kan vi sjekke at det fungerer på stagingsiden? Siden det ikke er laget eksempler fordi den er laget med storybook

Jag synes kanske ikke det er vert den dobbeljobben? Kan man sjekke ut branchen? Så kan vi se på den stagingjobben og storybook noen annen gang? Det vore greit med en fil men blir ju en høg før alla states og farger man kan ha. Storybook shines her

packages/ffe-chips-react/src/Chip.tsx

pethel · 2024-10-01T18:29:03Z

Jag gjorde noen justeringer. rigtIcon og leftIcon og vi tilater kun en per ganger.. det før att i framtiden kunna tillåta båda utan BREAKING CHANGE. chips i andre designsystemer har 2 ikoner :)

github-actions · 2024-10-01T22:37:11Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

github-actions · 2024-10-03T07:45:11Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

github-actions · 2024-10-03T08:42:09Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

tuva-odegard · 2024-10-03T12:29:02Z

Ser ut som at den får feil border på selectable/pressed state

antidecaf · 2024-10-03T12:57:16Z

transition ser ikke ut til å funke.

Propertyene må defineres hver for seg og kommasepareres på denne måten i stedet:

Det hadde også vært bra med cursor: pointer; på .ffe-chip for å indikere at den er klikkbar.

pethel · 2024-10-03T13:10:44Z

transition ser ikke ut til å funke.

Propertyene må defineres hver for seg og kommasepareres på denne måten i stedet:

Det hadde også vært bra med cursor: pointer; på .ffe-chip for å indikere at den er klikkbar.

Skall hade all først men det går ikke fordi da hopper allt omkring fordi griden også animaeras.

github-actions · 2024-10-03T13:19:56Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

pethel · 2024-10-03T13:44:29Z

Ser ut som at den får feil border på selectable/pressed state

Tatt en ny runda med borders nå. Gott opbservet

pethel · 2024-10-03T13:45:00Z

transition ser ikke ut til å funke.

Propertyene må defineres hver for seg og kommasepareres på denne måten i stedet:

Det hadde også vært bra med cursor: pointer; på .ffe-chip for å indikere at den er klikkbar.

Lagt på cursor: pointer efter avklaring med UX og tatt en nya runda med transitions

github-actions · 2024-10-03T13:47:44Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

github-actions · 2024-10-03T14:34:39Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

tuva-odegard · 2024-10-04T06:01:18Z

Lg får ikke riktig padding på høyresiden på removeable..

Hadde vært veldig fint å få opp et eksempel egentlig, det er litt kronglete å laste ned branchen for å sjekke neste gang du gjør en endring. Synes det er viktig å sjekke visuelt også

github-actions · 2024-10-04T07:30:12Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

github-actions · 2024-10-04T07:58:22Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

github-actions · 2024-10-04T08:21:58Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

github-actions · 2024-10-04T08:57:14Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2337.westeurope.2.azurestaticapps.net

pethel force-pushed the develop_chip branch from 48845a0 to 279c3c2 Compare October 1, 2024 13:11

pethel commented Oct 1, 2024

View reviewed changes

pethel force-pushed the develop_chip branch 2 times, most recently from 578e6ca to 6c0d6b4 Compare October 1, 2024 13:15

pethel commented Oct 1, 2024

View reviewed changes

pethel marked this pull request as ready for review October 1, 2024 13:30

pethel requested a review from a team as a code owner October 1, 2024 13:30

antidecaf reviewed Oct 1, 2024

View reviewed changes

packages/ffe-chips-react/src/Chip.tsx Outdated Show resolved Hide resolved

pethel requested a review from antidecaf October 1, 2024 14:17

pethel force-pushed the develop_chip branch 2 times, most recently from 5fbe993 to 2ce4b37 Compare October 1, 2024 18:27

pethel force-pushed the develop_chip branch from 2ce4b37 to 147f78a Compare October 1, 2024 22:32

pethel force-pushed the develop_chip branch from 147f78a to 175fbe7 Compare October 3, 2024 07:40

pethel force-pushed the develop_chip branch from 175fbe7 to 7909ff6 Compare October 3, 2024 08:37

docs(.storybook): added ffe-chips

7081826

pethel added 2 commits October 3, 2024 15:14

chore: added ffe-chips to commitlint

edcb0ad

feat(ffe-chips-react): initial commit

72f3166

pethel force-pushed the develop_chip branch from 7909ff6 to 1590416 Compare October 3, 2024 13:14

pethel force-pushed the develop_chip branch from 1590416 to e9eceba Compare October 3, 2024 13:42

pethel requested a review from tuva-odegard October 3, 2024 13:45

pethel force-pushed the develop_chip branch from e9eceba to cc68902 Compare October 3, 2024 14:29

pethel force-pushed the develop_chip branch from cc68902 to 5e43071 Compare October 4, 2024 07:25

pethel force-pushed the develop_chip branch from a82a14f to c5a8edd Compare October 4, 2024 08:16

pethel added 2 commits October 4, 2024 10:52

feat(ffe-chips): initial commit

8281c70

docs(component-overview): document chips

6beaaca

pethel force-pushed the develop_chip branch from c5a8edd to 6beaaca Compare October 4, 2024 08:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop chip #2337

Develop chip #2337

pethel commented Oct 1, 2024 •

edited

Loading

pethel Oct 1, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

pethel Oct 1, 2024

pethel Oct 1, 2024

pethel Oct 1, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

tuva-odegard commented Oct 1, 2024 •

edited by pethel

Loading

pethel commented Oct 1, 2024 •

edited

Loading

pethel commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

tuva-odegard commented Oct 3, 2024

antidecaf commented Oct 3, 2024

pethel commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

pethel commented Oct 3, 2024

pethel commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

tuva-odegard commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

Develop chip #2337

Are you sure you want to change the base?

Develop chip #2337

Conversation

pethel commented Oct 1, 2024 • edited Loading

pethel Oct 1, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

pethel Oct 1, 2024

Choose a reason for hiding this comment

pethel Oct 1, 2024

Choose a reason for hiding this comment

pethel Oct 1, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

tuva-odegard commented Oct 1, 2024 • edited by pethel Loading

pethel commented Oct 1, 2024 • edited Loading

pethel commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

tuva-odegard commented Oct 3, 2024

antidecaf commented Oct 3, 2024

pethel commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

pethel commented Oct 3, 2024

pethel commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

tuva-odegard commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

pethel commented Oct 1, 2024 •

edited

Loading

tuva-odegard commented Oct 1, 2024 •

edited by pethel

Loading

pethel commented Oct 1, 2024 •

edited

Loading