Small optimization

SparrowBrain · Apr 16, 2024 · d63a023 · d63a023
1 parent d0d31f7
commit d63a023
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/PlayNext/Model/Filters/RecentlyPlayedFilter.cs b/PlayNext/Model/Filters/RecentlyPlayedFilter.cs
@@ -15,9 +15,9 @@ public RecentlyPlayedFilter(IDateTimeProvider dateTimeProvider)
             _dateTimeProvider = dateTimeProvider;
         }
 
-        public IEnumerable<Game> Filter(IEnumerable<Game> games, int recentDayCount)
+        public IReadOnlyCollection<Game> Filter(IEnumerable<Game> games, int recentDayCount)
         {
-            return games.Where(x => x.LastActivity >= _dateTimeProvider.GetNow() - TimeSpan.FromDays(recentDayCount));
+            return games.Where(x => x.LastActivity >= _dateTimeProvider.GetNow() - TimeSpan.FromDays(recentDayCount)).ToList();
         }
     }
 }
diff --git a/PlayNext/PlayNext.cs b/PlayNext/PlayNext.cs
@@ -204,7 +204,9 @@ private void RefreshPlayNextData()
                     var recentGames = new RecentlyPlayedFilter(_dateTimeProvider).Filter(playedGames, recentDayCount);
                     var unPlayedGames = new UnplayedFilter().Filter(allGames, savedSettings).ToArray();
 
-                    var activitiesTask = _gameActivities.ParseGameActivity(recentGames);
+                    var activitiesTask = recentGames.Any()
+                        ? _gameActivities.ParseGameActivity(recentGames)
+                        : Task.CompletedTask;
                     var howLongToBeatTask = gameLengthWeight > 0
                         ? _howLongToBeatExtension.ParseFiles(unPlayedGames)
                         : Task.CompletedTask;

diff --git a/PlayNext/Settings/Old/SettingsVersions.md b/PlayNext/Settings/Old/SettingsVersions.md
@@ -1,2 +1,4 @@
 V3
-- StartPageMinCoverCount
+- StartPageMinCoverCount
+- SeriesWeight
+- OrderSeriesBy
diff --git a/ci/Changelog.txt b/ci/Changelog.txt
@@ -2,9 +2,10 @@ v1.5.0-------------------------
 - Added Brazilian Portuguese translations (thanks ?????????!)
 ----------- Series
 ----------- Extract StartPage Settings
------------ Improve game length algorithm (deviation by 0.5 from max length is the limit)
+----------- Improve game length algorithm (deviation by 0.5 from preferred length is the limit)
 ----------- Allow switching off sidebar item
 ----------- Fix init calculations
+----------- Optimize zero weight calculations
 
 v1.4.0
 - Added minimum cover count for use with start page alignments