Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4624 fix: missing error handling during sso login #1062

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

mistahj67
Copy link
Contributor

Description

  • Moved RedirectToLogin fn to api due to cyclic import requirement
  • Fixed redirect to actually redirect to login uri instead of root ui
  • Added additional error handling for session creation

Motivation and Context

This PR addresses: BED-4624

Why is this change required? What problem does it solve?
Support for displaying errors in the UI that occur during sso login

How Has This Been Tested?

Locally

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Jan 9, 2025
@mistahj67 mistahj67 self-assigned this Jan 9, 2025
Copy link
Contributor

@ALCooper12 ALCooper12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Changes make sense

@mistahj67 mistahj67 merged commit 6937675 into stage/v6.4.0 Jan 9, 2025
5 checks passed
@mistahj67 mistahj67 deleted the BED-4624 branch January 9, 2025 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants