Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BED-5069 feat: add sso config options to providers #990

Merged
merged 8 commits into from
Jan 2, 2025
Merged

BED-5069 feat: add sso config options to providers #990

merged 8 commits into from
Jan 2, 2025

Conversation

mistahj67
Copy link
Contributor

@mistahj67 mistahj67 commented Dec 2, 2024 •
edited
Loading

Description

  • Moved SAML / OIDC components under SSOProvider directory for easier management
  • Added SSOProviderConfigForm component to both UpsertSAMLProviderForm & UpsertOIDCProviderForm

Motivation and Context

This PR addresses: BED-5069

Why is this change required? What problem does it solve?
Provides ability to configure sso providers with auto provisioning support and display the configured values as well

How Has This Been Tested?

Unit tests / locally

Screenshots (optional):

image
image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

@mistahj67 mistahj67 added the user interface A pull request containing changes affecting the UI code. label Dec 2, 2024
@mistahj67 mistahj67 self-assigned this Dec 2, 2024
@mistahj67 mistahj67 force-pushed the BED-5009 branch 4 times, most recently from 7d0151f to b21b974 Compare December 2, 2024 20:41
@mistahj67 mistahj67 changed the title BED-5009 feat: add sso config options to providers BED-5069 feat: add sso config options to providers Dec 2, 2024
@mistahj67 mistahj67 force-pushed the BED-5009 branch 2 times, most recently from 6f08b90 to 67ca6ac Compare December 3, 2024 17:37
@mistahj67 mistahj67 marked this pull request as ready for review December 3, 2024 17:49
@benwaples
Copy link
Contributor

blocked until API side it complete

@benwaples benwaples added the blocked This pull request cannot be completed and should not be merged label Dec 10, 2024
@mistahj67 mistahj67 force-pushed the BED-5009 branch 2 times, most recently from d83341c to 82ada9e Compare December 24, 2024 00:48
@elikmiller
Copy link
Contributor

I pushed a small refactor related to how we mock ResizeObserver - by sticking the mock implementation in the setup test file we can avoid explicitly calling the mock implementation in each test.

https://vitest.dev/config/#setupfiles

elikmiller
elikmiller approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@elikmiller elikmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mistahj67 mistahj67 removed the blocked This pull request cannot be completed and should not be merged label Jan 2, 2025
@mistahj67 mistahj67 merged commit ec2580a into main Jan 2, 2025
5 checks passed
@mistahj67 mistahj67 deleted the BED-5009 branch January 2, 2025 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benwaples benwaples benwaples left review comments

@elikmiller elikmiller elikmiller approved these changes

Assignees

@mistahj67 mistahj67

Labels
user interface A pull request containing changes affecting the UI code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistahj67 @benwaples @elikmiller