Merge pull request #1137 from SpiNNakerManchester/roc_part

Pacman Typing information and some changes to make that easier
SpiNNakerManchester · Nov 1, 2023 · 234346c · 234346c
2 parents a22e5ef + 0bd4ee4
commit 234346c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/spinn_front_end_common/interface/splitter_selectors/splitter_selector.py b/spinn_front_end_common/interface/splitter_selectors/splitter_selector.py
@@ -24,13 +24,13 @@
 logger = FormatAdapter(logging.getLogger(__name__))
 
 
-def splitter_selector():
+def splitter_selector() -> None:
     """
     Basic selector which puts the legacy splitter object on
     everything without a splitter object.
     """
     for app_vertex in PacmanDataView.iterate_vertices():
-        if app_vertex.splitter is None:
+        if not app_vertex.has_splitter:
             vertex_selector(app_vertex)
 
 

diff --git a/spinn_front_end_common/utility_models/reverse_ip_tag_multicast_source_machine_vertex.py b/spinn_front_end_common/utility_models/reverse_ip_tag_multicast_source_machine_vertex.py
@@ -494,8 +494,8 @@ def _fill_send_buffer_2d(self, key_base):
         end_time_step = FecDataView.get_current_run_timesteps()
         if first_time_step == end_time_step:
             return
-        keys = get_field_based_keys(key_base, self._vertex_slice)
-        for atom in range(self._vertex_slice.n_atoms):
+        keys = get_field_based_keys(key_base, self.vertex_slice)
+        for atom in range(self.vertex_slice.n_atoms):
             for tick in sorted(self._send_buffer_times[atom]):
                 if self._is_in_range(tick, first_time_step, end_time_step):
                     self._send_buffer.add_key(tick, keys[atom])
@@ -512,8 +512,8 @@ def _fill_send_buffer_1d(self, key_base):
         end_time_step = FecDataView.get_current_run_timesteps()
         if first_time_step == end_time_step:
             return
-        keys = get_field_based_keys(key_base, self._vertex_slice)
-        key_list = [keys[atom] for atom in range(self._vertex_slice.n_atoms)]
+        keys = get_field_based_keys(key_base, self.vertex_slice)
+        key_list = [keys[atom] for atom in range(self.vertex_slice.n_atoms)]
         for tick in sorted(self._send_buffer_times):
             if self._is_in_range(tick, first_time_step, end_time_step):
                 self._send_buffer.add_keys(tick, key_list)