Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run methods #1244

Merged
merged 13 commits into from
Dec 30, 2024
Merged

Run methods #1244

merged 13 commits into from
Dec 30, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Nov 14, 2024 •
edited
Loading

Breaks up the ASB.__run method into many smaller methods.

As well as some refactoring to clean it up.

tested by
SpiNNakerManchester/sPyNNaker#1516 (to merge)
SpiNNakerManchester/IntegrationTests#304 (just close)

@Christian-B Christian-B mentioned this pull request Nov 14, 2024
Open
rowleya
rowleya approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to go in when Integration tests pass (or fail for the wrong reasons ;) )

@Christian-B Christian-B mentioned this pull request Dec 18, 2024
Merged
@Christian-B Christian-B merged commit 4c49c31 into master Dec 30, 2024
11 checks passed
@Christian-B Christian-B deleted the run_methods branch December 30, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowleya rowleya rowleya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christian-B @rowleya