Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Processor class #242

Closed
Christian-B opened this issue Mar 6, 2024 · 5 comments · Fixed by #244
Closed

Remove Processor class #242

Christian-B opened this issue Mar 6, 2024 · 5 comments · Fixed by #244

Comments

@Christian-B
Copy link
Member

The processors are indexed by ID in chip

With #237 the scamp(monitor) cores are kept separate from the "user" or none scamp ones.

So Processor.is_monitor is no longer used.

Processor methods dtcm_available, cpu_cycles_availabe and clock_speed return constant values.

Better to move these values to Version when and if anything cares!

@Christian-B
Copy link
Member Author

Christian-B commented Mar 6, 2024

The only thing Processor class could be used to is the mapping between virtual id, physical id and possibly for spin 2 coreY and coreX

Currently the Chip class already holds the virtual to physical mapping.
See #243

@Christian-B
Copy link
Member Author

Chip would just keep a list of scamp/monitor and user/none_scamp (Virtual) ids.

@Christian-B
Copy link
Member Author

If and when we need to include information on Processor Quads I still don't think the Processor class will help.

@Christian-B
Copy link
Member Author

farther examination shows the only place Processor class is used is in a unit test to use it as part of a vertex label

@Christian-B
Copy link
Member Author

Christian-B commented Mar 14, 2024

Fixed by #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant