-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip simplification #246
Merged
Chip simplification #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # spinn_machine/chip.py
# Conflicts: # spinn_machine/chip.py # unittests/test_chip.py
This was referenced Mar 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines/replaces #245, #244
Renaming:
In Chip/Processor:
"is_monitor" -> "scamp"
"user" -> "placable"
...Version
"n_non_user_cores" -> "n_scamp_cores"
TODO: "monitor" in Json passed to Java
Note: term "monitor" still kept for none graphs dependant vertices added to all Chips
Remove Processor Class
The Processor class has been removed.
Chip only provides tuples of scamp and placable processor ids
processors -> all_processor_ids
user_processors -> placable_processors_ids
monitor_processors -> scamp_processors_ids
get_first_none_monitor_processor -> placable_processors_ids[0]
Chip is now an X,Y tuple
The Chip class now extends tuple(int, int)
The equals and hash are handled by tuple(int,int)
This allows
This means:
The above now have meanings based on tuple(int,int) but there use is not recommended
Inlcudes:
SpiNNakerManchester/SpiNNMan#394
SpiNNakerManchester/PACMAN#548
SpiNNakerManchester/SpiNNFrontEndCommon#1165
SpiNNakerManchester/sPyNNaker#1439
SpiNNakerManchester/MarkovChainMonteCarlo#64
tested by:
SpiNNakerManchester/IntegrationTests#259