Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip simplification #246

Merged
merged 35 commits into from
Mar 15, 2024
Merged

Chip simplification #246

merged 35 commits into from
Mar 15, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Mar 13, 2024

Combines/replaces #245, #244

Renaming:

In Chip/Processor:
"is_monitor" -> "scamp"
"user" -> "placable"
...Version
"n_non_user_cores" -> "n_scamp_cores"
TODO: "monitor" in Json passed to Java
Note: term "monitor" still kept for none graphs dependant vertices added to all Chips

Remove Processor Class

The Processor class has been removed.

  • Version now has clock_speed_hz and dtcm_bytes
  • Processor.is_monitor now handled by Chip methods

Chip only provides tuples of scamp and placable processor ids

processors -> all_processor_ids
user_processors -> placable_processors_ids
monitor_processors -> scamp_processors_ids
get_first_none_monitor_processor -> placable_processors_ids[0]

Chip is now an X,Y tuple

The Chip class now extends tuple(int, int)
The equals and hash are handled by tuple(int,int)

This allows

  • (x,y) = chip
  • (x,y) and Chip objects to be used interchangeably as dict keys
  • A Chip object to be used anywhere and (x,y) is expected

This means:

  • Chip iter is no longer a tuple of it, processor
  • Chip[a] is no longer a processor
  • len(Chip) is no longer the number of processors
  • a in Chip is no longer a check for processor in chip
    The above now have meanings based on tuple(int,int) but there use is not recommended

Inlcudes:
SpiNNakerManchester/SpiNNMan#394
SpiNNakerManchester/PACMAN#548
SpiNNakerManchester/SpiNNFrontEndCommon#1165
SpiNNakerManchester/sPyNNaker#1439
SpiNNakerManchester/MarkovChainMonteCarlo#64

tested by:
SpiNNakerManchester/IntegrationTests#259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants