Skip to content

Commit

Permalink
minor fixes and style checks
Browse files Browse the repository at this point in the history
  • Loading branch information
Christian-B committed Jan 18, 2024
1 parent 9edd043 commit 64bc7b3
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1 deletion.
12 changes: 12 additions & 0 deletions .github/workflows/python_actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,15 @@ jobs:

- name: Test with nbmake
run: bash integration_tests/pytest.bash

- name: Lint with flake8
run: flake8 integration_tests spinnaker_jupyter_examples

- name: Lint with pylint
uses: ./support/actions/pylint
with:
package: ${{ env.BASE_PKG }}
exitcheck: 31 # Action fails on any message
language: en_GB


2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/.pydevproject
.ipynb_checkpoints
.pytest_cache
.pytest.bash
.pytest.bash
7 changes: 7 additions & 0 deletions integration_tests/bash_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ class BashBuilder(object):

def add_scripts(self, a_dir, prefix_len, test_file, exceptions):
"""
Adds a test(s) for a single file or to all in a directory
:param str a_dir:
:param int prefix_len:
:param io.TextIOBase test_file:
Expand All @@ -49,6 +51,11 @@ def add_scripts(self, a_dir, prefix_len, test_file, exceptions):
test_file.write("\n")

def build_bash(self, exceptions):
"""
Creates a bash file to run nbmake on all notebooks
:param exceptions: List of notebooks not to include
"""
class_file = sys.modules[self.__module__].__file__
# Ned this for python 3.8
class_file = os.path.abspath(class_file)
Expand Down

0 comments on commit 64bc7b3

Please sign in to comment.