Merge branch 'play' of https://github.com/SpiNNakerManchester/SpiNNak…

…erJupyterExamples into play
SpiNNakerManchester · Jan 18, 2024 · a8e430b · a8e430b
2 parents 419ada9 + 2162bd6
commit a8e430b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/python_actions.yml b/.github/workflows/python_actions.yml
@@ -25,7 +25,7 @@ jobs:
     timeout-minutes: 10
     strategy:
       matrix:
-        python-version: [3.9, "3.10", "3.11", "3.12"]
+        python-version: [3.8, "3.10", "3.11", "3.12"]
 
     steps:
     - name: Set up Python ${{ matrix.python-version }}

diff --git a/integration_tests/bash_builder.py b/integration_tests/bash_builder.py
@@ -30,6 +30,9 @@ def add_scripts(self, a_dir, prefix_len, test_file, exceptions):
         :param io.TextIOBase test_file:
         :param dict(str,str) exceptions:
         """
+        # for some reason python 3.8 passes an empty string here
+#        if not a_dir:
+#            return
         for a_script in os.listdir(a_dir):
             script_path = os.path.join(a_dir, a_script)
             if os.path.isdir(script_path) and not a_script.startswith("."):
@@ -53,6 +56,7 @@ def build_bash(self, exceptions):
         integration_dir = os.path.dirname(class_file)
         repository_dir = os.path.dirname(integration_dir)
 
+        print(class_file, integration_dir, repository_dir)
         test_script = os.path.join(integration_dir, "pytest.bash")
         header = os.path.join(integration_dir, "header.bash")
         copyfile(header, test_script)