Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing pot_auto_merge in gui raises error #82

Open
zm711 opened this issue Sep 11, 2024 · 3 comments
Open

Testing pot_auto_merge in gui raises error #82

zm711 opened this issue Sep 11, 2024 · 3 comments

Comments

@zm711
Copy link
Contributor

zm711 commented Sep 11, 2024

I just used get_ground_truth_recording to make an analyzer: got this error

  File ~\Documents\GitHub\spikeinterface-gui\spikeinterface_gui\pairlist.py:270 in compute
    self.pairs, self.merge_info = self.controller.compute_auto_merge(**params)

  File ~\Documents\GitHub\spikeinterface-gui\spikeinterface_gui\controller.py:405 in compute_auto_merge
    potential_merges, extra = get_potential_auto_merge(

TypeError: get_potential_auto_merge() got an unexpected keyword argument 'minimum_spikes'

I think after Pierre and Aurelien updated that this might take an update.

@FrancescoNegri
Copy link

FrancescoNegri commented Oct 24, 2024

Yeah, I encountered the same error, the parameters passed to get_potential_auto_merge() from the GUI are not the expected ones.
I could try to fix the auto merge dialog with the current SpikeInterface parameters, opening a pull request if this issue has not been solved yet.

@zm711
Copy link
Contributor Author

zm711 commented Oct 25, 2024

It has not @FrancescoNegri. I would say go ahead and do it. I keep planning on doing it, but it is low on my priority list and I think on Sam's too.

@samuelgarcia
Copy link
Member

Hi
after this is merged (normally tomorow) SpikeInterface/spikeinterface#3435
Il will fix it on sigui side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants