Changes to: Using Spinal from VSCodium #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor edits to make things clearer. Added some links.
I deleted the instructions which did not work for me on Mac oS X. Maybe they were for an older version of the Scala (Metal) extensions. Added some links and text and generally cleared up the page.
andreasWallner
requested changes
Oct 6, 2023
Co-authored-by: Andreas Wallner <A.Wallner@innovative-solutions.at>
Co-authored-by: Andreas Wallner <A.Wallner@innovative-solutions.at>
I agree with your comment that it may place people in the wrong directory. I prefer to access things this way, others may also. So I removed the name of the directory.
Co-authored-by: Andreas Wallner <A.Wallner@innovative-solutions.at>
So I dropped the search suggestion, and used your approach of giving them the path. That is also better, because the new user is learning the directory structure. And I reviewed the whole document again, added a period here, and a sentence or two there. Thank you for giving me the chance to learn how these tools work. Thank you for being so careful in how you do things, and in your blindingly fast response. It makes SpinalHDL look really really good.
andreasWallner
approved these changes
Oct 7, 2023
|
Thanks! you poked me a bit to review the other OSs installation instructions and update them... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed comments in the first and third commit messages.
Next time I will sync the repositories before editing.