Convert ObjectMapper to interface #133
Conversation
gabizou
added
the
breaking
There was a problem hiding this comment.
Just a couple of signature changes to make, I think. I'll take another look when I'm less tired.
As this does have a breaking change, this will likely be a 4.x change - so note that when this is ready, there may be a wait to pull until we have such a branch to accomodate it.
| @@ -66,81 +53,42 @@ | |||
| * @throws ObjectMappingException | |||
| */ | |||
| @SuppressWarnings("unchecked") | |||
| public static <T> ObjectMapper<T>.BoundInstance forObject(@NonNull T obj) throws ObjectMappingException { | |||
| static <T> BoundInstance forObject(@NonNull T obj) throws ObjectMappingException { | |||
There was a problem hiding this comment.
I guess this could be BoundInstance<T>?
|
|
||
| public Class<T> getMappedType() { | ||
| return this.clazz; | ||
| Object getInstance(); |
I tried to minimalize all possible breaking changes, thats why for example BoundInstance remained as an inner class. If we do not care about how much will stuff break, we can start a discussion whenever it would be beneficial to move ObjectMapper, BoundInstance and all annotations to its own explicit gradle submodule/package. |
ObjectMapper converted from class to interface, including BoundInstance.
In a nutshell
ObjectMapper is now ObjectMapperImpl implementing ObjectMapper interface
No packages were changed or renamed.
Theres only one breaking change, which users might or might not encounter; Depends on usage
I tried to search places where sponge could be affected found only this:
https://github.com/SpongePowered/SpongeCommon/blob/stable-7/src/main/java/org/spongepowered/common/config/SpongeConfig.java#L117
Should become
ObjectMapper.BoundInstance<T>