-
Notifications
You must be signed in to change notification settings - Fork 37
/
dxvk-async-f1aad6c.patch
494 lines (447 loc) · 15.9 KB
/
dxvk-async-f1aad6c.patch
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
diff --git a/meson.build b/meson.build
index 8fa3ce61..5e4d32d1 100644
--- a/meson.build
+++ b/meson.build
@@ -103,7 +103,7 @@ else
endif
dxvk_version = vcs_tag(
- command: ['git', 'describe', '--dirty=+'],
+ command: ['git', 'describe', '--dirty=-async'],
input: 'version.h.in',
output: 'version.h')
diff --git a/src/dxvk/dxvk_context.cpp b/src/dxvk/dxvk_context.cpp
index 797c4e20..bda90275 100644
--- a/src/dxvk/dxvk_context.cpp
+++ b/src/dxvk/dxvk_context.cpp
@@ -3837,7 +3837,9 @@ namespace dxvk {
: DxvkContextFlag::GpDirtyStencilRef);
// Retrieve and bind actual Vulkan pipeline handle
- m_gpActivePipeline = m_state.gp.pipeline->getPipelineHandle(m_state.gp.state, m_state.om.framebuffer->getRenderPass());
+ m_gpActivePipeline = m_state.gp.pipeline->getPipelineHandle(m_state.gp.state,
+ m_state.om.framebuffer->getRenderPass(),
+ this->checkAsyncCompilationCompat());
if (unlikely(!m_gpActivePipeline))
return false;
@@ -4093,7 +4095,7 @@ namespace dxvk {
}
- void DxvkContext::updateFramebuffer() {
+ void DxvkContext::updateFramebuffer(bool isDraw) {
if (m_flags.test(DxvkContextFlag::GpDirtyFramebuffer)) {
m_flags.clr(DxvkContextFlag::GpDirtyFramebuffer);
@@ -4114,6 +4116,11 @@ namespace dxvk {
m_state.gp.state.omSwizzle[i] = DxvkOmAttachmentSwizzle(mapping);
}
+ if (isDraw) {
+ for (uint32_t i = 0; i < fb->numAttachments(); i++)
+ fb->getAttachment(i).view->setRtBindingFrameId(m_device->getCurrentFrameId());
+ }
+
m_flags.set(DxvkContextFlag::GpDirtyPipelineState);
}
}
@@ -4343,7 +4350,7 @@ namespace dxvk {
}
if (m_flags.test(DxvkContextFlag::GpDirtyFramebuffer))
- this->updateFramebuffer();
+ this->updateFramebuffer(true);
if (!m_flags.test(DxvkContextFlag::GpRenderPassBound))
this->startRenderPass();
@@ -4772,6 +4779,14 @@ namespace dxvk {
}
}
+ bool DxvkContext::checkAsyncCompilationCompat() {
+ bool fbCompat = true;
+ for (uint32_t i = 0; fbCompat && i < m_state.om.framebuffer->numAttachments(); i++) {
+ const auto& attachment = m_state.om.framebuffer->getAttachment(i);
+ fbCompat &= attachment.view->getRtBindingAsyncCompilationCompat();
+ }
+ return fbCompat;
+ }
DxvkGraphicsPipeline* DxvkContext::lookupGraphicsPipeline(
const DxvkGraphicsPipelineShaders& shaders) {
diff --git a/src/dxvk/dxvk_context.h b/src/dxvk/dxvk_context.h
index 2456b20a..d58f1021 100644
--- a/src/dxvk/dxvk_context.h
+++ b/src/dxvk/dxvk_context.h
@@ -1159,7 +1159,7 @@ namespace dxvk {
VkDescriptorSet set,
const DxvkPipelineLayout* layout);
- void updateFramebuffer();
+ void updateFramebuffer(bool isDraw = false);
void updateIndexBufferBinding();
void updateVertexBufferBindings();
@@ -1211,6 +1211,8 @@ namespace dxvk {
void trackDrawBuffer();
+ bool checkAsyncCompilationCompat();
+
DxvkGraphicsPipeline* lookupGraphicsPipeline(
const DxvkGraphicsPipelineShaders& shaders);
diff --git a/src/dxvk/dxvk_graphics.cpp b/src/dxvk/dxvk_graphics.cpp
index 192e340b..96826600 100644
--- a/src/dxvk/dxvk_graphics.cpp
+++ b/src/dxvk/dxvk_graphics.cpp
@@ -62,17 +62,21 @@ namespace dxvk {
VkPipeline DxvkGraphicsPipeline::getPipelineHandle(
const DxvkGraphicsPipelineStateInfo& state,
- const DxvkRenderPass* renderPass) {
+ const DxvkRenderPass* renderPass,
+ bool async) {
DxvkGraphicsPipelineInstance* instance = nullptr;
- { std::lock_guard<sync::Spinlock> lock(m_mutex);
+ { //std::lock_guard<sync::Spinlock> lock(m_mutex);
instance = this->findInstance(state, renderPass);
if (instance)
return instance->pipeline();
- instance = this->createInstance(state, renderPass);
+ if (async && m_pipeMgr->m_compiler != nullptr)
+ m_pipeMgr->m_compiler->queueCompilation(this, state, renderPass);
+ else
+ instance = this->createInstance(state, renderPass);
}
if (!instance)
@@ -83,13 +87,13 @@ namespace dxvk {
}
- void DxvkGraphicsPipeline::compilePipeline(
+ bool DxvkGraphicsPipeline::compilePipeline(
const DxvkGraphicsPipelineStateInfo& state,
const DxvkRenderPass* renderPass) {
std::lock_guard<sync::Spinlock> lock(m_mutex);
- if (!this->findInstance(state, renderPass))
- this->createInstance(state, renderPass);
+ return (this->findInstance(state, renderPass) == nullptr) &&
+ (this->createInstance(state, renderPass) != nullptr);
}
@@ -103,6 +107,7 @@ namespace dxvk {
VkPipeline newPipelineHandle = this->createPipeline(state, renderPass);
+ std::lock_guard<sync::Spinlock> lock(m_mutex2);
m_pipeMgr->m_numGraphicsPipelines += 1;
return &m_pipelines.emplace_back(state, renderPass, newPipelineHandle);
}
@@ -111,6 +116,7 @@ namespace dxvk {
DxvkGraphicsPipelineInstance* DxvkGraphicsPipeline::findInstance(
const DxvkGraphicsPipelineStateInfo& state,
const DxvkRenderPass* renderPass) {
+ std::lock_guard<sync::Spinlock> lock(m_mutex2);
for (auto& instance : m_pipelines) {
if (instance.isCompatible(state, renderPass))
return &instance;
diff --git a/src/dxvk/dxvk_graphics.h b/src/dxvk/dxvk_graphics.h
index 4194599d..c48ee3ed 100644
--- a/src/dxvk/dxvk_graphics.h
+++ b/src/dxvk/dxvk_graphics.h
@@ -185,11 +185,13 @@ namespace dxvk {
* state. If necessary, a new pipeline will be created.
* \param [in] state Pipeline state vector
* \param [in] renderPass The render pass
+ * \param [in] async Compile asynchronously
* \returns Pipeline handle
*/
VkPipeline getPipelineHandle(
const DxvkGraphicsPipelineStateInfo& state,
- const DxvkRenderPass* renderPass);
+ const DxvkRenderPass* renderPass,
+ bool async);
/**
* \brief Compiles a pipeline
@@ -198,11 +200,16 @@ namespace dxvk {
* and stores the result for future use.
* \param [in] state Pipeline state vector
* \param [in] renderPass The render pass
+ * \returns \c true if compile succeeded
*/
- void compilePipeline(
+ bool compilePipeline(
const DxvkGraphicsPipelineStateInfo& state,
const DxvkRenderPass* renderPass);
+ void writePipelineStateToCache(
+ const DxvkGraphicsPipelineStateInfo& state,
+ const DxvkRenderPassFormat& format) const;
+
private:
Rc<vk::DeviceFn> m_vkd;
@@ -221,6 +228,7 @@ namespace dxvk {
// List of pipeline instances, shared between threads
alignas(CACHE_LINE_SIZE) sync::Spinlock m_mutex;
+ alignas(CACHE_LINE_SIZE) sync::Spinlock m_mutex2;
std::vector<DxvkGraphicsPipelineInstance> m_pipelines;
DxvkGraphicsPipelineInstance* createInstance(
@@ -248,10 +256,6 @@ namespace dxvk {
bool validatePipelineState(
const DxvkGraphicsPipelineStateInfo& state) const;
- void writePipelineStateToCache(
- const DxvkGraphicsPipelineStateInfo& state,
- const DxvkRenderPassFormat& format) const;
-
void logPipelineState(
LogLevel level,
const DxvkGraphicsPipelineStateInfo& state) const;
diff --git a/src/dxvk/dxvk_image.h b/src/dxvk/dxvk_image.h
index 19b5d85f..3da24c49 100644
--- a/src/dxvk/dxvk_image.h
+++ b/src/dxvk/dxvk_image.h
@@ -465,6 +465,37 @@ namespace dxvk {
return result;
}
+ /**
+ * \brief Sets render target usage frame number
+ *
+ * The image view will track internally when
+ * it was last used as a render target. This
+ * info is used for async shader compilation.
+ * \param [in] frameId Frame number
+ */
+ void setRtBindingFrameId(uint32_t frameId) {
+ if (frameId != m_rtBindingFrameId) {
+ if (frameId == m_rtBindingFrameId + 1)
+ m_rtBindingFrameCount += 1;
+ else
+ m_rtBindingFrameCount = 0;
+
+ m_rtBindingFrameId = frameId;
+ }
+ }
+
+ /**
+ * \brief Checks for async pipeline compatibility
+ *
+ * Asynchronous pipeline compilation may be enabled if the
+ * render target has been drawn to in the previous frames.
+ * \param [in] frameId Current frame ID
+ * \returns \c true if async compilation is supported
+ */
+ bool getRtBindingAsyncCompilationCompat() const {
+ return m_rtBindingFrameCount >= 5;
+ }
+
private:
Rc<vk::DeviceFn> m_vkd;
@@ -473,6 +504,9 @@ namespace dxvk {
DxvkImageViewCreateInfo m_info;
VkImageView m_views[ViewCount];
+ uint32_t m_rtBindingFrameId = 0;
+ uint32_t m_rtBindingFrameCount = 0;
+
void createView(VkImageViewType type, uint32_t numLayers);
};
diff --git a/src/dxvk/dxvk_options.cpp b/src/dxvk/dxvk_options.cpp
index 73dd69d1..c3da6bb5 100644
--- a/src/dxvk/dxvk_options.cpp
+++ b/src/dxvk/dxvk_options.cpp
@@ -10,6 +10,8 @@ namespace dxvk {
useRawSsbo = config.getOption<Tristate>("dxvk.useRawSsbo", Tristate::Auto);
useEarlyDiscard = config.getOption<Tristate>("dxvk.useEarlyDiscard", Tristate::Auto);
hud = config.getOption<std::string>("dxvk.hud", "");
+ enableAsync = config.getOption<bool> ("dxvk.enableAsync", false);
+ numAsyncThreads = config.getOption<int32_t> ("dxvk.numAsyncThreads", 0);
}
}
\ No newline at end of file
diff --git a/src/dxvk/dxvk_options.h b/src/dxvk/dxvk_options.h
index 3c5dde91..52a7be04 100644
--- a/src/dxvk/dxvk_options.h
+++ b/src/dxvk/dxvk_options.h
@@ -21,6 +21,13 @@ namespace dxvk {
/// when using the state cache
int32_t numCompilerThreads;
+ // Enable async pipelines
+ bool enableAsync;
+
+ /// Number of compiler threads
+ /// when using async pipelines
+ int32_t numAsyncThreads;
+
/// Shader-related options
Tristate useRawSsbo;
Tristate useEarlyDiscard;
diff --git a/src/dxvk/dxvk_pipecompiler.cpp b/src/dxvk/dxvk_pipecompiler.cpp
new file mode 100644
index 00000000..40218acd
--- /dev/null
+++ b/src/dxvk/dxvk_pipecompiler.cpp
@@ -0,0 +1,76 @@
+#include "dxvk_device.h"
+#include "dxvk_graphics.h"
+#include "dxvk_pipecompiler.h"
+
+namespace dxvk {
+
+ DxvkPipelineCompiler::DxvkPipelineCompiler(const DxvkDevice* device) {
+ uint32_t numCpuCores = dxvk::thread::hardware_concurrency();
+ uint32_t numWorkers = ((std::max(1u, numCpuCores) - 1) * 5) / 7;
+
+ if (numWorkers < 1) numWorkers = 1;
+ if (numWorkers > 32) numWorkers = 32;
+
+ if (device->config().numAsyncThreads > 0)
+ numWorkers = device->config().numAsyncThreads;
+
+ Logger::info(str::format("DXVK: Using ", numWorkers, " async compiler threads"));
+
+ // Start the compiler threads
+ m_compilerThreads.resize(numWorkers);
+
+ for (uint32_t i = 0; i < numWorkers; i++) {
+ m_compilerThreads.at(i) = dxvk::thread(
+ [this] { this->runCompilerThread(); });
+ }
+ }
+
+
+ DxvkPipelineCompiler::~DxvkPipelineCompiler() {
+ { std::lock_guard<std::mutex> lock(m_compilerLock);
+ m_compilerStop.store(true);
+ }
+
+ m_compilerCond.notify_all();
+ for (auto& thread : m_compilerThreads)
+ thread.join();
+ }
+
+
+ void DxvkPipelineCompiler::queueCompilation(
+ DxvkGraphicsPipeline* pipeline,
+ const DxvkGraphicsPipelineStateInfo& state,
+ const DxvkRenderPass* renderPass) {
+ std::lock_guard<std::mutex> lock(m_compilerLock);
+ m_compilerQueue.push({ pipeline, state, renderPass });
+ m_compilerCond.notify_one();
+ }
+
+
+ void DxvkPipelineCompiler::runCompilerThread() {
+ env::setThreadName("dxvk-pcompiler");
+
+ while (!m_compilerStop.load()) {
+ PipelineEntry entry;
+
+ { std::unique_lock<std::mutex> lock(m_compilerLock);
+
+ m_compilerCond.wait(lock, [this] {
+ return m_compilerStop.load()
+ || m_compilerQueue.size() != 0;
+ });
+
+ if (m_compilerQueue.size() != 0) {
+ entry = std::move(m_compilerQueue.front());
+ m_compilerQueue.pop();
+ }
+ }
+
+ if (entry.pipeline != nullptr && entry.renderPass != nullptr &&
+ entry.pipeline->compilePipeline(entry.state, entry.renderPass)) {
+ entry.pipeline->writePipelineStateToCache(entry.state, entry.renderPass->format());
+ }
+ }
+ }
+
+}
diff --git a/src/dxvk/dxvk_pipecompiler.h b/src/dxvk/dxvk_pipecompiler.h
new file mode 100644
index 00000000..d7fcc2cf
--- /dev/null
+++ b/src/dxvk/dxvk_pipecompiler.h
@@ -0,0 +1,61 @@
+#pragma once
+
+#include <atomic>
+#include <condition_variable>
+#include <mutex>
+#include <queue>
+
+#include "../util/thread.h"
+#include "dxvk_include.h"
+
+namespace dxvk {
+
+ class DxvkDevice;
+ class DxvkGraphicsPipeline;
+ class DxvkGraphicsPipelineStateInfo;
+
+ /**
+ * \brief Pipeline compiler
+ *
+ * Asynchronous pipeline compiler
+ */
+ class DxvkPipelineCompiler : public RcObject {
+
+ public:
+
+ DxvkPipelineCompiler(const DxvkDevice* device);
+ ~DxvkPipelineCompiler();
+
+ /**
+ * \brief Compiles a pipeline asynchronously
+ *
+ * This should be used to compile graphics
+ * pipeline instances asynchronously.
+ * \param [in] pipeline The pipeline object
+ * \param [in] state The pipeline state info object
+ * \param [in] renderPass
+ */
+ void queueCompilation(
+ DxvkGraphicsPipeline* pipeline,
+ const DxvkGraphicsPipelineStateInfo& state,
+ const DxvkRenderPass* renderPass);
+
+ private:
+
+ struct PipelineEntry {
+ DxvkGraphicsPipeline* pipeline = nullptr;
+ DxvkGraphicsPipelineStateInfo state;
+ const DxvkRenderPass* renderPass = nullptr;
+ };
+
+ std::atomic<bool> m_compilerStop = { false };
+ std::mutex m_compilerLock;
+ std::condition_variable m_compilerCond;
+ std::queue<PipelineEntry> m_compilerQueue;
+ std::vector<dxvk::thread> m_compilerThreads;
+
+ void runCompilerThread();
+
+ };
+
+}
diff --git a/src/dxvk/dxvk_pipemanager.cpp b/src/dxvk/dxvk_pipemanager.cpp
index 2e29202e..1e767381 100644
--- a/src/dxvk/dxvk_pipemanager.cpp
+++ b/src/dxvk/dxvk_pipemanager.cpp
@@ -9,7 +9,11 @@ namespace dxvk {
DxvkRenderPassPool* passManager)
: m_device (device),
m_cache (new DxvkPipelineCache(device->vkd())) {
+ std::string useAsync = env::getEnvVar("DXVK_ASYNC");
std::string useStateCache = env::getEnvVar("DXVK_STATE_CACHE");
+
+ if (useAsync == "1" || device->config().enableAsync)
+ m_compiler = new DxvkPipelineCompiler(device);
if (useStateCache != "0" && device->config().enableStateCache)
m_stateCache = new DxvkStateCache(device, this, passManager);
diff --git a/src/dxvk/dxvk_pipemanager.h b/src/dxvk/dxvk_pipemanager.h
index 858928ca..4c12a4dc 100644
--- a/src/dxvk/dxvk_pipemanager.h
+++ b/src/dxvk/dxvk_pipemanager.h
@@ -6,6 +6,7 @@
#include "dxvk_compute.h"
#include "dxvk_graphics.h"
+#include "dxvk_pipecompiler.h"
namespace dxvk {
@@ -95,6 +96,7 @@ namespace dxvk {
const DxvkDevice* m_device;
Rc<DxvkPipelineCache> m_cache;
Rc<DxvkStateCache> m_stateCache;
+ Rc<DxvkPipelineCompiler> m_compiler;
std::atomic<uint32_t> m_numComputePipelines = { 0 };
std::atomic<uint32_t> m_numGraphicsPipelines = { 0 };
diff --git a/src/dxvk/meson.build b/src/dxvk/meson.build
index 1dc113c3..003fb1a7 100644
--- a/src/dxvk/meson.build
+++ b/src/dxvk/meson.build
@@ -83,6 +83,7 @@ dxvk_src = files([
'dxvk_openvr.cpp',
'dxvk_options.cpp',
'dxvk_pipecache.cpp',
+ 'dxvk_pipecompiler.cpp',
'dxvk_pipelayout.cpp',
'dxvk_pipemanager.cpp',
'dxvk_queue.cpp',