Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Python 3.8 (remove 3.6) #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circle/exit_on_py3_checks
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

# Script which checks exit code of "test" script under Python 3.6 environment
# Script which checks exit code of "test" script under Python 3.8 environment
# and exists with an appropriate code
if [[ $# -lt 1 ]] ; then
echo "Usage: $0 <test script exit code>"
Expand Down
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ version: 2
jobs:
test_py36:
docker:
- image: circleci/python:3.6
- image: circleci/python:3.8

working_directory: ~/ci

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/enable-pack-build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ permissions:

jobs:
enable_pack_build_and_test_workflow:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
name: Enable Pack Build and Test workflow

steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/index-update.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ on:
python-version:
required: false
type: string
default: "3.6"
default: "3.8"

jobs:
regenerate_index:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
# When parent workflow is named "Update Index" this shows up as:
# "Update Index / Regenerate"
name: Regenerate
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pack-bootstrap_repo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ on:
required_check_context:
type: string
required: false
default: "Build and Test / Python 3.6"
default: "Build and Test / Python 3.8"
required_check_app_id:
type: string
required: false
Expand All @@ -61,7 +61,7 @@ on:

jobs:
bootstrap_pack_repo:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
name: 'Bootstrap Repo'
env:
# GH_TOKEN used by `gh` command
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pack-build_and_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
python-version:
required: false
type: string
default: '["3.6","3.8","3.9"]'
default: '["3.8","3.9"]'
enable-common-libs:
description: |
When true, use an st2.conf that sets packs.enable_common_libs=true
Expand All @@ -37,9 +37,9 @@ on:

jobs:
build_and_test:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
# When parent workflow is named "Build and Test" this shows up as:
# "Build and Test / Python 3.6,3.8,3.9"
# "Build and Test / Python 3.8,3.9"
name: 'Python ${{ matrix.python-version }}'
strategy:
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pack-repo_meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:

jobs:
repo_meta:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
name: 'Repo Metadata'

outputs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pack-tag_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:

jobs:
tag_release:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
name: 'Tag Release'

outputs:
Expand Down
4 changes: 2 additions & 2 deletions utils/.circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
# not considered fatal
build_and_test_python36:
docker:
- image: circleci/python:3.6
- image: circleci/python:3.8
- image: rabbitmq:3
- image: mongo:3.4

Expand All @@ -77,7 +77,7 @@ jobs:
git clone -b master git://github.com/stackstorm-exchange/ci.git ~/ci
~/ci/.circle/dependencies ; ~/ci/.circle/exit_on_py3_checks $?
- run:
name: Run tests (Python 3.6)
name: Run tests (Python 3.8)
# NOTE: We don't want to use default "-e" option because this means
# step will fail immediately on one of the commands failures and we
# can't intercept the error and cause non-fatal exit in case pack
Expand Down