Fix a bug with gunicorn master process not shutting down.

The problem was that we performed eventlet monkey patching inside master instead
of only inside workers which broke signal handling (master never received
signals so it never shut down).

st2api/st2api/app.py

@@ -14,7 +14,9 @@
 # limitations under the License.
 
 import os
+import sys
 
+import eventlet
 import pecan
 from oslo_config import cfg
 from pecan.middleware.static import StaticFileMiddleware
@@ -52,6 +54,16 @@ def setup_app(config=None):
 
     is_gunicorn = getattr(config, 'is_gunicorn', False)
     if is_gunicorn:
+        # Note: We need to perform monkey patching in the worker. If we do it in
+        # the master process (gunicorn_config.py), it breaks tons of things
+        # including shutdown
+        eventlet.monkey_patch(
+            os=True,
+            select=True,
+            socket=True,
+            thread=False if '--use-debugger' in sys.argv else True,
+            time=True)
+
         st2api_config.register_opts()
         # This should be called in gunicorn case because we only want
         # workers to connect to db, rabbbitmq etc. In standalone HTTP

st2api/st2api/gunicorn_config.py

@@ -21,21 +21,11 @@
 from __future__ import absolute_import
 
 import os
-import sys
-
-import eventlet
 
 __all__ = [
     'app'
 ]
 
-eventlet.monkey_patch(
-    os=True,
-    select=True,
-    socket=True,
-    thread=False if '--use-debugger' in sys.argv else True,
-    time=True)
-
 bind = '127.0.0.1:9101'
 
 config_args = ['--config-file', os.environ.get('ST2_CONFIG_PATH', '/etc/st2/st2.conf')]

st2auth/st2auth/app.py

@@ -13,6 +13,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import sys
+
+import eventlet
 import pecan
 from oslo_config import cfg
 
@@ -44,6 +47,16 @@ def setup_app(config=None):
 
     is_gunicorn = getattr(config, 'is_gunicorn', False)
     if is_gunicorn:
+        # Note: We need to perform monkey patching in the worker. If we do it in
+        # the master process (gunicorn_config.py), it breaks tons of things
+        # including shutdown
+        eventlet.monkey_patch(
+            os=True,
+            select=True,
+            socket=True,
+            thread=False if '--use-debugger' in sys.argv else True,
+            time=True)
+
         # This should be called in gunicorn case because we only want
         # workers to connect to db, rabbbitmq etc. In standalone HTTP
         # server case, this setup would have already occurred.

st2auth/st2auth/gunicorn_config.py

@@ -21,21 +21,11 @@
 from __future__ import absolute_import
 
 import os
-import sys
-
-import eventlet
 
 __all__ = [
     'app'
 ]
 
-eventlet.monkey_patch(
-    os=True,
-    select=True,
-    socket=True,
-    thread=False if '--use-debugger' in sys.argv else True,
-    time=True)
-
 bind = '127.0.0.1:9100'
 
 config_args = ['--config-file', os.environ.get('ST2_CONFIG_PATH', '/etc/st2/st2.conf')]

st2stream/st2stream/app.py

@@ -23,7 +23,9 @@
 """
 
 import os
+import sys
 
+import eventlet
 import pecan
 from oslo_config import cfg
 
@@ -56,6 +58,13 @@ def setup_app(config=None):
 
     is_gunicorn = getattr(config, 'is_gunicorn', False)
     if is_gunicorn:
+        eventlet.monkey_patch(
+            os=True,
+            select=True,
+            socket=True,
+            thread=False if '--use-debugger' in sys.argv else True,
+            time=True)
+
         st2stream_config.register_opts()
         # This should be called in gunicorn case because we only want
         # workers to connect to db, rabbbitmq etc. In standalone HTTP

st2stream/st2stream/gunicorn_config.py

@@ -21,21 +21,11 @@
 from __future__ import absolute_import
 
 import os
-import sys
-
-import eventlet
 
 __all__ = [
     'app'
 ]
 
-eventlet.monkey_patch(
-    os=True,
-    select=True,
-    socket=True,
-    thread=False if '--use-debugger' in sys.argv else True,
-    time=True)
-
 bind = '127.0.0.1:9101'
 
 config_args = ['--config-file', os.environ.get('ST2_CONFIG_PATH', '/etc/st2/st2.conf')]