Skip to content

Commit

Permalink
fix: PVC should use claimName key
Browse files Browse the repository at this point in the history
When using `claim-name` for persistent pack volumes, the following error
is raised by Helm:

```
> helm upgrade my-st2 stackstorm/stackstorm-ha --values values.yaml --debug
upgrade.go:144: [debug] preparing upgrade for my-st2
Error: UPGRADE FAILED: error validating "": error validating data: [ValidationError(Deployment.spec.template.spec.volumes[2].persistentVolumeClaim): unknown field "claim-name" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[2].persistentVolumeClaim): missing required field "claimName" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[3].persistentVolumeClaim): unknown field "claim-name" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[3].persistentVolumeClaim): missing required field "claimName" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[4].persistentVolumeClaim): unknown field "claim-name" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource, ValidationError(Deployment.spec.template.spec.volumes[4].persistentVolumeClaim): missing required field "claimName" in io.k8s.api.core.v1.PersistentVolumeClaimVolumeSource]
```

Fix by using `claimName` instead for `persistentVolumeClaim` sections.
  • Loading branch information
fuhrmannb committed Jul 25, 2023
1 parent f49658a commit ed4b7a8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,10 @@ For example, to use persistentVolumeClaims:
enabled: true
packs:
persistentVolumeClaim:
claim-name: pvc-st2-packs
claimName: pvc-st2-packs
virtualenvs:
persistentVolumeClaim:
claim-name: pvc-st2-virtualenvs
claimName: pvc-st2-virtualenvs
```

Or, for example, to use NFS:
Expand Down Expand Up @@ -286,7 +286,7 @@ For example, to use persistentVolumeClaims:
... # define packs and virtualenvs volumes as shown above
configs:
persistentVolumeClaim:
claim-name: pvc-st2-pack-configs
claimName: pvc-st2-pack-configs
```

Or, for example, to use NFS:
Expand Down
2 changes: 1 addition & 1 deletion values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ st2:

# example using persistentVolumeClaim:
#persistentVolumeClaim:
# claim-name: pvc-st2-packs
# claimName: pvc-st2-packs

# example using NFS:
#nfs:
Expand Down

0 comments on commit ed4b7a8

Please sign in to comment.