Feature/stij 129: Make inline buttons the default #111
Conversation
| @@ -14,7 +14,7 @@ | |||
| {% include '@h6' with { 'h6_text': 'Heading 6' } %} | |||
| {% include '@paragraph' with { 'text': 'Normal text below an heading 6.'} %} | |||
| {% include '@paragraph' with { 'text': 'Paragraphs <a href="#">link</a>'} %} | |||
| <p>{% include '@button-sm' with { 'text': 'Button'} %}</p> | |||
| <p>{% include '@button' with { 'text': 'Button'} %}</p> | |||
There was a problem hiding this comment.
Would it not be better to use the same names for placeholders and the corresponding buttons in Sass
There was a problem hiding this comment.
I changed this. What do you think?
| We also provide a SASS placeholder. | ||
|
|
||
| ## Small buttons | ||
| * `%btn--small` |
There was a problem hiding this comment.
Why do we implement two different button classes? This is a bit confusing. Placeholder for extends is ok.
There was a problem hiding this comment.
I think this is meant to be backwards compatible.
There was a problem hiding this comment.
@Jeroen005 can you check if these button classes are still necessary?
There was a problem hiding this comment.
Classy is using .button if I'm not mistaking.
There was a problem hiding this comment.
Ah ok. If that is the case we should leave it in for now untill we have time to refactor the basetheme to strip the classy classes and add the styleguide markup
| // | ||
| @mixin btn-block { | ||
| display: block; | ||
| width: 100%; |
There was a problem hiding this comment.
width: 100% is not necessary, since you declare your element as a block which has a default width of 100%.
| @@ -21,15 +21,23 @@ | |||
| } | |||
|
|
|||
| // | |||
| // Button display | |||
| // Button inline display (default). | |||
| // | |||
| @mixin btn-inlineblock { | |||
| display: inline-block; | |||
| width: auto; | |||
There was a problem hiding this comment.
Width auto should not be necessary in this context
meirege
changed the title
meirege
changed the title
No description provided.