This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
ON HOLD: STIJ-183: POC - footer with CSS Grid and flexbox fallback. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delrueba
approved these changes
Nov 29, 2017
Jeroen005
suggested changes
Nov 29, 2017
.sass-lint.yml
Outdated
| @@ -33,7 +33,7 @@ rules: | |||
| no-debug: 2 | |||
| # We use sizes in rem followed by px for these | |||
| no-duplicate-properties: | |||
| - 2 | |||
| - 0 | |||
There was a problem hiding this comment.
please exclude the display in this rule instead of changing the error level
| .db-block-partnership { | ||
| @include desktop { | ||
| margin-top: 12.5rem; | ||
| .footer--column:last-child { |
There was a problem hiding this comment.
alignment of the molecule should me added on the molecule itself, not on the grid system.
…fic styling to the right molecule.
Jeroen005
approved these changes
Nov 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
POC of using CSS Grid in a component like the footer.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: