This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Feature/open 57: Openingsuren component (STIJ-238) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OPEN-57 # Conflicts: # components/_preview.twig
…OPEN-57 # Conflicts: # components/41-organisms/header/header.twig
meirege
reviewed
Nov 29, 2017
| "title": "Openinghours", | ||
| "name": "openinghours", | ||
| "status": "alpha", | ||
| "preview": "@preview", |
There was a problem hiding this comment.
I don't think this is necessary if you use the default preview.
delrueba
suggested changes
Nov 29, 2017
| element.innerHTML = data; | ||
| }; | ||
|
|
||
| var openinghours = { |
| this.s = Object.assign({}, defaults, options); | ||
| this.items = items; | ||
|
|
||
| for (var i = 0; i < items.length; i++) { |
There was a problem hiding this comment.
try for(var i = items.length; i--;)
This will only calculate the length of your array once, plus comparing to zero is faster.
Only really matters for very big arrays, but it's a nice habit ;)
https://stackoverflow.com/questions/1340589/are-loops-really-faster-in-reverse
| OpeningHours.prototype.constructRequest = function () { | ||
| switch (this._current.dataset.type) { | ||
| case 'open-now': | ||
| return this.s.endpoint + '/api/v1/services/' + this._current.dataset.service + '/channels/' + this._current.dataset.channel + '/open-now'; |
There was a problem hiding this comment.
I'd put these strings in a function variable, so it's easy to change version numbers etc.
Jeroen005
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: